Skip to content

x/build: upgrade netbsd-386 and netbsd-amd64 builders to pick up recent libpthread fixes #54773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bsiegert opened this issue Aug 30, 2022 · 10 comments
Closed

x/build: upgrade netbsd-386 and netbsd-amd64 builders to pick up recent libpthread fixes #54773

bsiegert opened this issue Aug 30, 2022 · 10 comments
Assignees
@cagedmantis @bsiegert
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD
Milestone
Unreleased

Comments

@bsiegert
Copy link
Contributor

There are a few ongoing issues that are potentially related to kernel bugs in NetBSD (possibly related to #50496).

There was a new NetBSD stable release, 9.3, that fixes a large number of such bugs. Perhaps some of the hard-to-diagnose bugs that keep cropping up have been actually fixed upstream. (I certainly hope so!)

I can send a CL to bump the versions in /x/build. However, as I remember, at some point, a member of @golang/release needs to actually create the image, or I can do that on a corp workstation and provide a link to an image.

/cc @golang/netbsd
@bsiegert bsiegert self-assigned this Aug 30, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 30, 2022
@gopherbot gopherbot added this to the Unreleased milestone Aug 30, 2022
@cagedmantis
Copy link
Contributor

I think sending a CL to bump the version in x/build would be the desired path.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/428415 mentions this issue: env/netbsd-*: update builder VMs to NetBSD 9.3

@bcmills bcmills mentioned this issue Oct 12, 2022
Closed
@bcmills
Copy link
Contributor

bcmills commented Oct 14, 2022

Per #50138 (comment), we should upgrade the NetBSD builders to a post-9.3 build that includes the libpthread fix (CC @riastradh).

@bcmills bcmills changed the title x/build: move netbsd-386 and netbsd-amd64 builders to NetBSD 9.3 x/build: upgrade netbsd-386 and netbsd-amd64 builders to pick up recent libpthread fixes Oct 14, 2022
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 14, 2022
@bcmills bcmills mentioned this issue Oct 14, 2022
Closed
gopherbot pushed a commit to golang/build that referenced this issue Nov 7, 2022
@bsiegert
env/netbsd-*: update builder VMs to latest NetBSD-9
24869eb 
The packages are taken from the 2022Q2 branch. These are built for
the 9.0 release, as is usual upstream, but all 9.x releases are binary
compatible.

There are a few other refactorings in this CL to make future maintenance
simpler.

Update golang/go#54773

Change-Id: I38a8eab1aabd9985771ac83da2e435e490b7e4b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/428415
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Benny Siegert <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/450235 mentions this issue: dashboard: add netbBSD 9.3 builders

gopherbot pushed a commit to golang/build that referenced this issue Nov 14, 2022
@cagedmantis
dashboard: add NetBSD 9.3 builders

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
036509d 
This adds the 9.3 builders created by running the make file and
manually uploading and creating the VM images.

Updates golang/go#54773

Change-Id: I0826b1fea1c486ec7cb34abad539672bddc39bb7
Reviewed-on: https://go-review.googlesource.com/c/build/+/450235
Run-TryBot: Carlos Amedee <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Joedian Reid <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/450615 mentions this issue: go: use testenv.Command instead of exec.Command in tests

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/450715 mentions this issue: dashboard, cmd/racebuild: promote NetBSD 9.3 as the primary builder version

@joedian joedian moved this to In Progress in Go Release Nov 15, 2022
gopherbot pushed a commit to golang/build that referenced this issue Nov 15, 2022
@cagedmantis
dashboard, cmd/racebuild: promote NetBSD 9.3 as the primary builder v…
e1e518f 
…ersion

This change removed the known issue from the NetBSD 9.3 builders.
It also promotes 9.3 to be the primary version of NetBSD used in the
build infrastructure.

Updates golang/go#54773

Change-Id: If8b8aa89edb9ed8be564149ea728715b4a7b1085
Reviewed-on: https://go-review.googlesource.com/c/build/+/450715
Run-TryBot: Carlos Amedee <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Jenny Rakoczy <[email protected]>
Reviewed-by: Benny Siegert <[email protected]>
gopherbot pushed a commit that referenced this issue Nov 15, 2022
@gopherbot
go: use testenv.Command instead of exec.Command in tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a171f3f 
This may help to diagnose whether the hang observed in
https://build.golang.org/log/d03db1d27515a4f7e91502e8b58bc83f6e2c04be
is related to #56180.

Updates #56180.
Updates #54773.

Change-Id: I81d37e55a35f876905ceabc103fcf0d1ff348e2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/450615
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
@bcmills
Copy link
Contributor

bcmills commented Nov 28, 2022

@bsiegert, is there anything remaining to be done for this? (Do the older builders still need to be turned down, or configured to only run on release branches?)

@toothrot toothrot added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 29, 2022
@bsiegert
Copy link
Contributor Author

Yes, the *-9_0 builders should be turned down. Should I send a CL removing them from the dashboard?

@cagedmantis
Copy link
Contributor

@bsiegert It would be great if you did. Thank you.

@cagedmantis cagedmantis removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 30, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/454755 mentions this issue: dashboard: remove NetBSD 9.0 builders

Repository owner moved this from In Progress to Done in Go Release Dec 2, 2022
@bcmills bcmills mentioned this issue Aug 20, 2023
Open
@golang golang locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cagedmantis cagedmantis

@bsiegert bsiegert

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@toothrot @cagedmantis @bsiegert @bcmills @gopherbot