Closed
Description
In the pull request #55068 it turned out that the package hash must not depend on encoding/binary.
In my opinion, if this was allowed, the code would be cleaner (I recommend to see the proposed changes in the PR) and the practical difference would not be much, since encoding/binary has little code in it that does what is needed.
Furthermore, this package is already used as a replacement for the append/put uint32/64 functions in the crypto package.
I therefore propose to allow the use of encoding/binary also in the hash package and avoid code duplication.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
dsnet commentedon Sep 16, 2022
I don't think this needs to be a proposal. At the end of the day, the reason why we can't use
encoding/binary
in a number of places is due to: #54097.rsc commentedon Sep 28, 2022
This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group
rsc commentedon Oct 5, 2022
As Joe noted, this is not something we can do.
rsc commentedon Oct 12, 2022
Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group
rsc commentedon Oct 20, 2022
No change in consensus, so declined.
— rsc for the proposal review group