Skip to content

proposal: hash: permit usage of encoding/binary package #55104

Closed
@ErikPelli

Description

@ErikPelli

In the pull request #55068 it turned out that the package hash must not depend on encoding/binary.
In my opinion, if this was allowed, the code would be cleaner (I recommend to see the proposed changes in the PR) and the practical difference would not be much, since encoding/binary has little code in it that does what is needed.

Furthermore, this package is already used as a replacement for the append/put uint32/64 functions in the crypto package.
I therefore propose to allow the use of encoding/binary also in the hash package and avoid code duplication.

Activity

added this to the Proposal milestone on Sep 16, 2022
dsnet

dsnet commented on Sep 16, 2022

@dsnet
Member

I don't think this needs to be a proposal. At the end of the day, the reason why we can't use encoding/binary in a number of places is due to: #54097.

moved this to Incoming in Proposalson Sep 16, 2022
moved this from Incoming to Active in Proposalson Sep 28, 2022
rsc

rsc commented on Sep 28, 2022

@rsc
Contributor

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

rsc

rsc commented on Oct 5, 2022

@rsc
Contributor

As Joe noted, this is not something we can do.

moved this from Active to Likely Decline in Proposalson Oct 12, 2022
rsc

rsc commented on Oct 12, 2022

@rsc
Contributor

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

rsc

rsc commented on Oct 20, 2022

@rsc
Contributor

No change in consensus, so declined.
— rsc for the proposal review group

moved this from Likely Decline to Declined in Proposalson Oct 20, 2022
locked and limited conversation to collaborators on Oct 20, 2023
removed this from Proposalson Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @rsc@dsnet@gopherbot@ErikPelli

        Issue actions

          proposal: hash: permit usage of encoding/binary package · Issue #55104 · golang/go