Skip to content

x/tools/gopls: deprecate experimentalWatchedFileDelay #55268

Closed
@findleyr

Description

@findleyr

I added experimentalWatchedFileDelay for LSP clients that don't buffer file change notifications. In retrospect, I think this was a mistake:

  • Clients have more knowledge of user intent, and so are better fit to implement change buffering (e.g. during branch switches)
  • Clients should control the ordering of changes. By buffering change notifications gopls observes a different ordering of changes than is sent by the client. This shouldn't matter in practice, but feels incorrect.
  • Change processing should be fast. In some sense, this setting was only working around a limitation of gopls that it had to do a remarkable amount of bookkeeping for each change. We've since improved that significantly (https://go.dev/issue/45686).

Therefore, I think we should remove this setting (which never made it out of 'experimental' anyway), to reduce complexity within gopls.

Metadata

Metadata

Assignees

Labels

FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions