Skip to content

x/net/http2: server writes after timeout should return os.ErrDeadlineExceeded #56478

Closed
@neild

Description

@neild

A HTTP/2 handler that writes to the ResponseWriter after Server.WriteTimeout has expired gets a http2: stream closed error. It should get an error for which errors.Is(err, os.ErrDeadlineExceeded) is true.

Activity

gopherbot

gopherbot commented on Oct 28, 2022

@gopherbot
Contributor

Change https://go.dev/cl/446255 mentions this issue: net/http: add tests for Server.ReadTimeout and server.WriteTimeout

gopherbot

gopherbot commented on Oct 28, 2022

@gopherbot
Contributor

Change https://go.dev/cl/446257 mentions this issue: http2: return os.ErrDeadlineExceeded from timed-out response body writes

added
NeedsFixThe path to resolution is known, but the work has not been done.
on Nov 1, 2022
modified the milestones: Unplanned, Go1.20 on Nov 19, 2022
modified the milestones: Go1.20, Go1.21 on Feb 1, 2023
modified the milestones: Go1.21, Go1.22 on Aug 8, 2023
odeke-em

odeke-em commented on Jan 25, 2024

@odeke-em
Member

@neild I believe you fixed this issue in https://go-review.googlesource.com/c/net/+/446257 hence I shall close this issue, please reopen if otherwise and thank you for reporting plus fixing it!

locked and limited conversation to collaborators on Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @neild@odeke-em@gopherbot@seankhliao

        Issue actions

          x/net/http2: server writes after timeout should return os.ErrDeadlineExceeded · Issue #56478 · golang/go