misc/cgo/test: static test fails #56623
Labels
arch-loong64
Issues solely affecting the loongson architecture.
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
aclements
added
the
NeedsInvestigation
|
Change https://go.dev/cl/448016 mentions this issue: |
aclements
added
the
arch-loong64
|
Thank you very much， I will try to solve this problem |
gopherbot
pushed a commit
that referenced
this issue
Nov 16, 2022
The cmd/dist cgo_test enumerates a large number of platforms in various special cases. Some combinations are suspiciously absent. This CL completes the combinations. I've confirmed using trybots that the newly-enabled tests pass on android/* (this is not surprising because the gohostos is never "android" anyway), windows/arm64, linux/ppc64 (no cgo), linux/loong64 (except for one test, filed #56623), linux/mips*, netbsd/arm (except for one test, filed #56629), and netbsd/arm64. The windows/arm builder is out to lunch, so I'm assuming that works. Since netbsd/arm and arm64 mostly passed these tests, I've also enabled them on netbsd/386 and netbsd/amd64, where they seem to work fine as well. Preparation for #37486. Change-Id: I04c3348e4f422d74d51e714647ca3db379e6e919 Reviewed-on: https://go-review.googlesource.com/c/go/+/448016 Run-TryBot: Austin Clements <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Austin Clements <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
|
Change https://go.dev/cl/416154 mentions this issue: |
|
Another instance: https://build.golang.org/log/40befeb1926223b8194ffd6ff76777e20f81a434 CL 416154 is supposed to have this fixed though. |
xen0n
pushed a commit
to xen0n/go
that referenced
this issue
Mar 17, 2023
Refer to CL 413428 and 412474, for loong64, like mips, s390x and riscv, there is no single instruction that saves the LR and decrements the SP, so we also need to insert an instruction to save the LR after decrementing the SP. Fixes golang#56623. Updates golang#53374. Change-Id: I3de040792f0a041d3d2a98ea89c23a2dd2f4ad10
johanbrandhorst
pushed a commit
to Pryz/go
that referenced
this issue
Mar 28, 2023
Refer to CL 413428 and 412474, for loong64, like mips, s390x and riscv, there is no single instruction that saves the LR and decrements the SP, so we also need to insert an instruction to save the LR after decrementing the SP. Fixes golang#56623. Updates golang#53374. Change-Id: I3de040792f0a041d3d2a98ea89c23a2dd2f4ad10 Reviewed-on: https://go-review.googlesource.com/c/go/+/416154 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Cherry Mui <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: WANG Xuerui <[email protected]> Reviewed-by: xiaodong liu <[email protected]> Run-TryBot: Cherry Mui <[email protected]> Reviewed-by: Meidan Li <[email protected]>
xen0n
pushed a commit
to xen0n/go
that referenced
this issue
May 1, 2023
Refer to CL 413428 and 412474, for loong64, like mips, s390x and riscv, there is no single instruction that saves the LR and decrements the SP, so we also need to insert an instruction to save the LR after decrementing the SP. Fixes golang#56623. Updates golang#53374. Change-Id: I3de040792f0a041d3d2a98ea89c23a2dd2f4ad10 Reviewed-on: https://go-review.googlesource.com/c/go/+/416154 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Cherry Mui <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: WANG Xuerui <[email protected]> Reviewed-by: xiaodong liu <[email protected]> Run-TryBot: Cherry Mui <[email protected]> Reviewed-by: Meidan Li <[email protected]> (cherry picked from commit 3ed8a1e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version)?581a822 in the Go 1.20 development tree
What operating system and processor architecture are you using (
go env)?linux/loong64, observed on the trybots for CL 448016 PS 1
What did you do?
I've been enabling dist tests for cgo on more architectures where it's not clear why they're disabled. One of the misc/cgo/test static build configurations crashes on linux/loong64. It's unfortunately not easy to extract tests from dist (something I'm hoping to improve), but I believe this is what the test is doing:
What did you expect to see?
Test passes.
What did you see instead?
Test crashes with "signal: bus error" (trybot log)
/cc @golang/loong64
The text was updated successfully, but these errors were encountered: