-
Notifications
You must be signed in to change notification settings - Fork 18k
net/http: access to written data after ResponseWriter.Write returns #58446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
Change https://go.dev/cl/467055 mentions this issue: |
Change https://go.dev/cl/467355 mentions this issue: |
Change https://go.dev/cl/467657 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Feb 13, 2023
Pull in HTTP/2 fix to deflake builders: 547e7edf38 http2: avoid referencing ResponseWrite.Write parameter after returning For #58446 Change-Id: I7f3666bc1f20ee03a7ccf25f0e091033cbc635d7 Reviewed-on: https://go-review.googlesource.com/c/go/+/467657 Auto-Submit: Damien Neil <[email protected]> Run-TryBot: Damien Neil <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
johanbrandhorst
pushed a commit
to Pryz/go
that referenced
this issue
Feb 22, 2023
Pull in HTTP/2 fix to deflake builders: 547e7edf38 http2: avoid referencing ResponseWrite.Write parameter after returning For golang#58446 Change-Id: I7f3666bc1f20ee03a7ccf25f0e091033cbc635d7 Reviewed-on: https://go-review.googlesource.com/c/go/+/467657 Auto-Submit: Damien Neil <[email protected]> Run-TryBot: Damien Neil <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
The HTTP/2
ResponseWriter
can access the contents of the slice passed toWrite
afterWrite
returns.This is a violation of the
io.Writer
contract, and responsible for a number of recentnet/http
flakes.The text was updated successfully, but these errors were encountered: