Skip to content

cmd/gopherbot: move "ping-early-issues" task to relui #58856

Closed
@dmitshur

Description

@dmitshur

Pinging issues with "early-in-cycle" is a task that we do once every 6 months, after the development of a new major Go version starts. Right now it's implemented as a task in gopherbot that needs to be explicitly run with -only-run=ping-early-issues flag (and provide a URL of the reopening announcement via the openTreeURLs map).

Now that we have relui, this task can move there. Not only is it slightly easier to trigger the task via a web UI, it also eliminates the need of setting up credentials for running goperbot on a local workstation. Having it in relui also opens future opportunities like eventually making it a part of a larger "reopen tree for development" workflow, etc.

This is the tracking issue for moving the task to relui. To avoid bringing in the maintner dependency into relui, I'll also rewrite it to use GitHub API v4 (GraphQL) instead and use it as an opportunity to see what that looks like.

CC @golang/release.

Activity

added
Buildersx/build issues (builders, bots, dashboards)
NeedsFixThe path to resolution is known, but the work has not been done.
on Mar 3, 2023
added this to the Unreleased milestone on Mar 3, 2023
self-assigned this
on Mar 3, 2023
moved this to In Progress in Go Releaseon Mar 3, 2023
gopherbot

gopherbot commented on Mar 4, 2023

@gopherbot
Contributor

Change https://go.dev/cl/473160 mentions this issue: cmd/relui: add a "ping early-in-cycle issues" workflow

gopherbot

gopherbot commented on Mar 4, 2023

@gopherbot
Contributor

Change https://go.dev/cl/473159 mentions this issue: cmd/gopherbot: replace maintner with GitHub API v4 in ping-early-issues

moved this from In Progress to Planned in Go Releaseon May 9, 2023
moved this from Planned to In Progress in Go Releaseon Jul 18, 2023
dmitshur

dmitshur commented on Jul 25, 2023

@dmitshur
MemberAuthor

This is done and worked to ping early issues in the Go 1.22 milestone recently.

This was also a bit of an exercise to see if GitHub's GraphQL API can help when moving away from maintner as a dependency. My conclusion is that it helps a bit, but using maintner (if it works) is still so much nicer and simpler.

There's a harmless TODO in code to decide "if it's worth moving the GraphQL query/mutation". I had the idea of possibly moving the query into GitHubClientInterface, but that really means moving the entire task's implementation there. I don't think it's worth it now, but can revisit this later.

moved this from In Progress to Done in Go Releaseon Jul 25, 2023
locked and limited conversation to collaborators on Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Buildersx/build issues (builders, bots, dashboards)FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

Type

No type

Projects

Status

Done

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @dmitshur@gopherbot

      Issue actions

        cmd/gopherbot: move "ping-early-issues" task to relui · Issue #58856 · golang/go