x/tools/gopls: strange error in type checking #60904
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
gopherbot
added
Tools
|
Change https://go.dev/cl/504695 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jun 20, 2023
Updates golang/go#60904 Change-Id: Ia9f259716732705060a0d3675cd701c6c68a215f Reviewed-on: https://go-review.googlesource.com/c/tools/+/504695 gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Alan Donovan <[email protected]> Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Alan Donovan <[email protected]>
|
Change https://go.dev/cl/504815 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jun 21, 2023
Also tidy and add back the replace directive. For golang/go#60917 Conflicts: - gopls/go.mod - gopls/go.sum Merge List: + 2023-06-20 85554d6 gopls/internal/lsp/cache: add debugging assertion for golang/go#60904 + 2023-06-20 9960b69 gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID + 2023-06-20 6480332 gopls/internal/lsp/cache: use types.Unsafe in analysisPackage + 2023-06-20 155320d gopls/internal/lsp/work: don't crash when hovering over broken mod dir + 2023-06-20 b71392a gopls/internal/lsp/cache: reduce importing in analysis + 2023-06-20 d1a388b internal/gcimporter: avoid a crash when exporting a struct with no pkg + 2023-06-16 a4ed05f cmd/digraph: add "to dot" to emit Graphviz dot + 2023-06-15 7261b32 gopls/internal/regtest: fix goimports on windows when using vendoring + 2023-06-14 41e4e56 gopls/internal/lsp/source/completion: ensuring completion completeness + 2023-06-14 ac29460 go/ssa: fix bug in writeSignature on external functions + 2023-06-14 3b62e7e go/ssa: use core type within (*builder).receiver + 2023-06-14 f394d45 gopls/internal/lsp/cache: compute xrefs and methodsets asynchronously + 2023-06-14 27dbf85 go.mod: update golang.org/x dependencies + 2023-06-13 c6c9830 go/types/objectpath: memoize scope lookup in objectpath.Encoder + 2023-06-13 0245e1d gopls/internal/regtest/codelens: set GOWORK=off for go mod vendor + 2023-06-13 85be888 go/analysis/passes/defers: add analyser for defer mistake + 2023-06-13 c43232f cmd/digraph: improve examples using go list, mod + 2023-06-12 6e1595c internal/gcimporter: treat unknown constant values the same as invalid + 2023-06-12 c59d87f gopls/internal/lsp/cache: two minor simplifications + 2023-06-10 db6a81e go/packages/packagestest: set Config.Logf if the test is run verbosely + 2023-06-06 a01290f internal/typeparams: work around LookupFieldOrMethod inconsistency + 2023-06-05 6f567c8 gopls/internal/lsp/filecache: reduce lifespan of os.FileInfos + 2023-06-05 726c727 gopls/internal/lsp: enable min/max builtin completion test Change-Id: I85926c5d711102941750ad122844c10d13acc09a
|
We believe this was fixed by https://go.dev/cl/505219. |
leitzler
added a commit
to govim/govim
that referenced
this issue
Jun 26, 2023
* gopls/internal/lsp/cache: don't panic when import fails during analysis fa103593d * gopls/internal/lsp/cache: don't record edges to invalid packages c8278fe90 * cmd/godoc: disable TestWebIndex, a very slow test 87df9bcac * gopls/internal/lsp/cache: remove ITVs from shared import graph 63624dfc8 * gopls/internal/lsp/cache: fix nil panic in analysis toSourceDiagnostic 0ca9d30bb * gopls/internal/lsp/cache: add debugging assertion for golang/go#60904 85554d61b * gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID 9960b693c * gopls/internal/lsp/cache: use types.Unsafe in analysisPackage 6480332be * gopls/internal/lsp/work: don't crash when hovering over broken mod dir 155320d39 * gopls/internal/lsp/cache: reduce importing in analysis b71392afd * internal/gcimporter: avoid a crash when exporting a struct with no pkg d1a388b0e * cmd/digraph: add "to dot" to emit Graphviz dot a4ed05f16 * gopls/internal/regtest: fix goimports on windows when using vendoring 7261b3269 * gopls/internal/lsp/source/completion: ensuring completion completeness 41e4e5654 * go/ssa: fix bug in writeSignature on external functions ac2946029 * go/ssa: use core type within (*builder).receiver 3b62e7e25 * gopls/internal/lsp/cache: compute xrefs and methodsets asynchronously f394d451f * go.mod: update golang.org/x dependencies 27dbf8527 * go/types/objectpath: memoize scope lookup in objectpath.Encoder c6c983054 * gopls/internal/regtest/codelens: set GOWORK=off for go mod vendor 0245e1dfc * go/analysis/passes/defers: add analyser for defer mistake 85be8882c * cmd/digraph: improve examples using go list, mod c43232f86 * internal/gcimporter: treat unknown constant values the same as invalid 6e1595c15 * gopls/internal/lsp/cache: two minor simplifications c59d87f5d * go/packages/packagestest: set Config.Logf if the test is run verbosely db6a81ed1 * internal/typeparams: work around LookupFieldOrMethod inconsistency a01290f98 * gopls/internal/lsp/filecache: reduce lifespan of os.FileInfos 6f567c809 * gopls/internal/lsp: enable min/max builtin completion test 726c727df * gopls: unimported completion should use the completion matcher 86c93e873 * gopls/internal/lsp/source: fix panic in typeDefinition on comparable 04ceacbfb * gopls/internal/lsp/source/methodsets: comparable also has no package 947adca51 * gopls/internal/lsp/cache: add assertions c35c44fa0 * internal/diff: fix LineEdits bug in slow path 0b4461bab * internal/diff: fix LineEdits bug in fast path 1943c1e3e * go/pointer: delete package c6d86c4f3 * go/types/objectpath: remove unnecessary unsafe import 77fd064f3 * go/pointer: remove replace directive 0dda7d614 * gopls/internal/lsp/cache: check number of orphaned files after filtering 98f1b4dee * go/pointer: create submodule a260315e3 * cmd/{guru,callgraph}: stop using go/pointer 96844c359 * go/packages: include "unsafe".GoFiles=["unsafe.go"] cd694d8db * gopls/internal/lsp: add min/max builtin 33c741de7 * internal/lsp/source: use exact match in import highlighting 933c7ccb1 * gopls/internal/lsp: clear vuln diagnostics on config changes 5974258e6 * go/packages: pass -pgo=off on go1.21 and later f3faea198 * internal/lsp/debug: add links to profiles and GC 5f74ec7da * internal/diff: unexport various identifiers ed90c6d20 * gopls/internal/lsp/source: test references bug on struct{p.T} 827f5aa2c * go/ssa/interp: implement min/max builtins a12e1a6ae * gopls/internal/lsp/cache: remove nested module warning 9c97539a2 * gopls/internal/lsp/cmd: add a stats -anon flag to show anonymous data d44a094d8 * gopls/internal/lsp: bundle certain quick-fixes with their diagnostic e106694df * gopls/internal/lsp/filecache: reenable memory cache layer 5dc3f7433 * gopls/internal/lsp/cmd: simplify connection type 7e146a6c6 * gopls/internal/regtest/workspace: unskip duplicate modules test 1e6066861 * gopls/doc: Fix broken links 5ce721db5 * gopls/internal/lsp/cmd: remove vestiges of debugging golang/go#59475 7a03febee * gopls/internal/regtest/misc: update and unskip TestHoverIntLiteral a70f2bc21 * gopls/internal/regtest/misc: unskip TestMajorOptionsChange 6997d196f * gopls/internal/lsp/cache: fix crash in Session.updateViewLocked ec543c5a2 * gopls/internal/regtest/misc: update some unilaterally skipped tests a12ee94f7 * gopls: deprecate support for Go 1.16 and 1.17, update warnings 5ff5cbb00 * gopls/internal/lsp/cache: limit module scan to 100K files e6fd7f4c0 * gopls/internal/lsp/regtest: delete TestWatchReplaceTargets 9ca66ba88 * gopls/internal/lsp/source/completion: (unimported) add placeholders edbfdbebf * gopls: add a new "subdirWatchPatterns" setting 3a5dbf351 * internal/typesinternal: remove NewObjectpathFunc 3c0255176 * present: reformat doc comment for lack of inline code 07293620c * go/ssa: TestStdlib: disable check that function names are distinct d4e66bd9a * go/ssa: use core type for field accesses 738ea2bdc * gopls/internal/lsp: split file-watching glob patterns 2ec4299f3 * gopls/internal/lsp/cache: only delete the most relevant mod tidy handle 43b02eab0 * internal/lsp/filecache: eliminate 'kind' directories 5919673c9 * gopls/internal/lsp: keep track of overlays on the files map a5ef6c3eb * gopls/internal/lsp/mod: optimizations for mod tidy diagnostics d7f4359f8 * gopls/internal/lsp/filecache: touch only files older than 1h 2eb726b88 * gopls/internal/regtest/bench: add a benchmark for diagnosing saves b742cb9a5 * gopls/internal/lsp/cache: tweak error message 4d66324ee * gopls/internal/lsp/filecache: delayed tweaks from code review e46df400e * gopls/internal/lsp/debug: remove memory monitoring 3df69b827 * gopls/internal/lsp/filecache: avoid flock a069704d0 * gopls/internal/lsp/cache: fix race in adhoc reloading 3d53c2d20 * go/analysis/passes/slog: fix Group kv offset 8b4b27bce * cover: eliminate an unnecessary fsync in TestParseProfiles 242e5ed73 * go/ssa: fix typo in package docs 651d951bb * gopls/internal/lsp/debug: limit to 100 recent trace entries 743372f58 * go/ssa/interp: avoid hard-coding GOOS and GOARCH 522243a71 * gopls/internal/lsp/cache: fail workspace load on context cancellation a0593829f * gopls/internal/lsp/cache: unexport ValidBuildConfiguration e5c8d4db7 * go/ssa: use core type for composite literal addresses f4e8a711a * go/ssa: use core types for array length 3b25dbddd * gopls/internal/lsp/filecache: front with a 100MB in-memory LRU cache e7048d518 * gopls/internal/lsp/lru: extract LRU logic to a standalone package 8c0fcd2c6 * go/ssa/interp: use the actual GOOS and GOARCH to interpret tests 19d700c67 * gopls/internal/lsp/filecache: limit Get parallelism too 9dcd3d5dc * go/ssa: consolidate use of underlying pointer 7f203f0c3 * gopls/internal/lsp: add quick-fixes to manage the go.work file a13793e31 * internal/gcimporter: improve error handling 12a0517ad * gopls/internal/lsp/cache: call filecache.Set asynchronously 5eb1eb932 * gopls/internal/lsp/filecache: limit parallelism in Set 35fe77a6b * gopls: improve diagnostics for orphaned files 1c9fe3f82 * go/gcexportdata: drop support for the ancient binary format ad74ff634
leitzler
added a commit
to govim/govim
that referenced
this issue
Jun 26, 2023
* gopls/internal/lsp/cache: don't panic when import fails during analysis fa103593d * gopls/internal/lsp/cache: don't record edges to invalid packages c8278fe90 * cmd/godoc: disable TestWebIndex, a very slow test 87df9bcac * gopls/internal/lsp/cache: remove ITVs from shared import graph 63624dfc8 * gopls/internal/lsp/cache: fix nil panic in analysis toSourceDiagnostic 0ca9d30bb * gopls/internal/lsp/cache: add debugging assertion for golang/go#60904 85554d61b * gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID 9960b693c * gopls/internal/lsp/cache: use types.Unsafe in analysisPackage 6480332be * gopls/internal/lsp/work: don't crash when hovering over broken mod dir 155320d39 * gopls/internal/lsp/cache: reduce importing in analysis b71392afd * internal/gcimporter: avoid a crash when exporting a struct with no pkg d1a388b0e * cmd/digraph: add "to dot" to emit Graphviz dot a4ed05f16 * gopls/internal/regtest: fix goimports on windows when using vendoring 7261b3269 * gopls/internal/lsp/source/completion: ensuring completion completeness 41e4e5654 * go/ssa: fix bug in writeSignature on external functions ac2946029 * go/ssa: use core type within (*builder).receiver 3b62e7e25 * gopls/internal/lsp/cache: compute xrefs and methodsets asynchronously f394d451f * go.mod: update golang.org/x dependencies 27dbf8527 * go/types/objectpath: memoize scope lookup in objectpath.Encoder c6c983054 * gopls/internal/regtest/codelens: set GOWORK=off for go mod vendor 0245e1dfc * go/analysis/passes/defers: add analyser for defer mistake 85be8882c * cmd/digraph: improve examples using go list, mod c43232f86 * internal/gcimporter: treat unknown constant values the same as invalid 6e1595c15 * gopls/internal/lsp/cache: two minor simplifications c59d87f5d * go/packages/packagestest: set Config.Logf if the test is run verbosely db6a81ed1 * internal/typeparams: work around LookupFieldOrMethod inconsistency a01290f98 * gopls/internal/lsp/filecache: reduce lifespan of os.FileInfos 6f567c809 * gopls/internal/lsp: enable min/max builtin completion test 726c727df * gopls: unimported completion should use the completion matcher 86c93e873 * gopls/internal/lsp/source: fix panic in typeDefinition on comparable 04ceacbfb * gopls/internal/lsp/source/methodsets: comparable also has no package 947adca51 * gopls/internal/lsp/cache: add assertions c35c44fa0 * internal/diff: fix LineEdits bug in slow path 0b4461bab * internal/diff: fix LineEdits bug in fast path 1943c1e3e * go/pointer: delete package c6d86c4f3 * go/types/objectpath: remove unnecessary unsafe import 77fd064f3 * go/pointer: remove replace directive 0dda7d614 * gopls/internal/lsp/cache: check number of orphaned files after filtering 98f1b4dee * go/pointer: create submodule a260315e3 * cmd/{guru,callgraph}: stop using go/pointer 96844c359 * go/packages: include "unsafe".GoFiles=["unsafe.go"] cd694d8db * gopls/internal/lsp: add min/max builtin 33c741de7 * internal/lsp/source: use exact match in import highlighting 933c7ccb1 * gopls/internal/lsp: clear vuln diagnostics on config changes 5974258e6 * go/packages: pass -pgo=off on go1.21 and later f3faea198 * internal/lsp/debug: add links to profiles and GC 5f74ec7da * internal/diff: unexport various identifiers ed90c6d20 * gopls/internal/lsp/source: test references bug on struct{p.T} 827f5aa2c * go/ssa/interp: implement min/max builtins a12e1a6ae * gopls/internal/lsp/cache: remove nested module warning 9c97539a2 * gopls/internal/lsp/cmd: add a stats -anon flag to show anonymous data d44a094d8 * gopls/internal/lsp: bundle certain quick-fixes with their diagnostic e106694df * gopls/internal/lsp/filecache: reenable memory cache layer 5dc3f7433 * gopls/internal/lsp/cmd: simplify connection type 7e146a6c6 * gopls/internal/regtest/workspace: unskip duplicate modules test 1e6066861 * gopls/doc: Fix broken links 5ce721db5 * gopls/internal/lsp/cmd: remove vestiges of debugging golang/go#59475 7a03febee * gopls/internal/regtest/misc: update and unskip TestHoverIntLiteral a70f2bc21 * gopls/internal/regtest/misc: unskip TestMajorOptionsChange 6997d196f * gopls/internal/lsp/cache: fix crash in Session.updateViewLocked ec543c5a2 * gopls/internal/regtest/misc: update some unilaterally skipped tests a12ee94f7 * gopls: deprecate support for Go 1.16 and 1.17, update warnings 5ff5cbb00 * gopls/internal/lsp/cache: limit module scan to 100K files e6fd7f4c0 * gopls/internal/lsp/regtest: delete TestWatchReplaceTargets 9ca66ba88 * gopls/internal/lsp/source/completion: (unimported) add placeholders edbfdbebf * gopls: add a new "subdirWatchPatterns" setting 3a5dbf351 * internal/typesinternal: remove NewObjectpathFunc 3c0255176 * present: reformat doc comment for lack of inline code 07293620c * go/ssa: TestStdlib: disable check that function names are distinct d4e66bd9a * go/ssa: use core type for field accesses 738ea2bdc * gopls/internal/lsp: split file-watching glob patterns 2ec4299f3 * gopls/internal/lsp/cache: only delete the most relevant mod tidy handle 43b02eab0 * internal/lsp/filecache: eliminate 'kind' directories 5919673c9 * gopls/internal/lsp: keep track of overlays on the files map a5ef6c3eb * gopls/internal/lsp/mod: optimizations for mod tidy diagnostics d7f4359f8 * gopls/internal/lsp/filecache: touch only files older than 1h 2eb726b88 * gopls/internal/regtest/bench: add a benchmark for diagnosing saves b742cb9a5 * gopls/internal/lsp/cache: tweak error message 4d66324ee * gopls/internal/lsp/filecache: delayed tweaks from code review e46df400e * gopls/internal/lsp/debug: remove memory monitoring 3df69b827 * gopls/internal/lsp/filecache: avoid flock a069704d0 * gopls/internal/lsp/cache: fix race in adhoc reloading 3d53c2d20 * go/analysis/passes/slog: fix Group kv offset 8b4b27bce * cover: eliminate an unnecessary fsync in TestParseProfiles 242e5ed73 * go/ssa: fix typo in package docs 651d951bb * gopls/internal/lsp/debug: limit to 100 recent trace entries 743372f58 * go/ssa/interp: avoid hard-coding GOOS and GOARCH 522243a71 * gopls/internal/lsp/cache: fail workspace load on context cancellation a0593829f * gopls/internal/lsp/cache: unexport ValidBuildConfiguration e5c8d4db7 * go/ssa: use core type for composite literal addresses f4e8a711a * go/ssa: use core types for array length 3b25dbddd * gopls/internal/lsp/filecache: front with a 100MB in-memory LRU cache e7048d518 * gopls/internal/lsp/lru: extract LRU logic to a standalone package 8c0fcd2c6 * go/ssa/interp: use the actual GOOS and GOARCH to interpret tests 19d700c67 * gopls/internal/lsp/filecache: limit Get parallelism too 9dcd3d5dc * go/ssa: consolidate use of underlying pointer 7f203f0c3 * gopls/internal/lsp: add quick-fixes to manage the go.work file a13793e31 * internal/gcimporter: improve error handling 12a0517ad * gopls/internal/lsp/cache: call filecache.Set asynchronously 5eb1eb932 * gopls/internal/lsp/filecache: limit parallelism in Set 35fe77a6b * gopls: improve diagnostics for orphaned files 1c9fe3f82 * go/gcexportdata: drop support for the ancient binary format ad74ff634
myitcv
added a commit
to myitcvforks/govim
that referenced
this issue
Jul 19, 2023
* gopls/internal/lsp/cache: better panic if metadata invariant is broken 84f829e27 * gopls/internal/lsp/cache: frob: a fast encoder with gob-like powers 03275ec1a * gopls/internal/lsp: don't awaitLoaded inside resolveImportGraph dbfa51380 * gopls/internal/lsp: fix a latent bug in orphaned file reloading b16097183 * internal/facts: strength-reduce Package param to PackagePath 67aade56d * gopls/internal/lsp/source/typerefs: optimize getPackageHandles ffc82f3af * gopls/internal/lsp: only diagnose one package per file 50a6ef662 * internal/gcimporter: don't panic when exporting a builtin 'Error' method 48026e1f7 * gopls/protocol/generate: upgrade generating LSP stubs 5fed7a883 * gopls/internal/lsp/debug: display Analysis.Run times b9fd8df27 * gopls/internal: update LSP support 799eec0fd * gopls/internal/lsp/source: fix spurious "unexpected var object" error c6de5f512 * gopls/internal/regtest/bench: add a test simulating typing ba3c31c94 * gopls/internal/regtest/bench: add an 'oracle' benchmark repo 80c9aad95 * gopls/internal/regtest/bench: clean up profile flags e10bcf6a4 * go/types/internal/play: show enclosing scopes and method sets 50a7e142c * internal/typeparams: improve the panic in OriginMethod 12fe14902 * internal/gcimporter: supporting encoding objects from different packages 89d9fae1d * go/analysis: remove pointless comments dbd600188 * internal/gopathwalk: use opts.Logf for errors if set 67d73b296 * go/analysis: pass package's Go version to type checker 1ca21856a * gopls/internal/regtest/workspace: fix TestQuickFix_AddGoWork for go1.21 a721062d8 * internal/analysisutil: avoid IsNamed panic on built-in named types ba23fc4ab * go/analysis/passes/slog: unskip test e1d0f9142 * gopls: commands to start/stop profiling, and a new benchmark metric c35476fcc * internal/gopathwalk: use os.ReadFile instead of ioutil.ReadFile ec9bc5342 * internal/cmd/deadcode: a command to report dead code in Go programs aac7fb67a * gopls/internal/lsp/source: put context first in extracted functions 538a6e9ed * internal/lsp/analysis: embed directive analyzer check following decl ef1254549 * internal: fix typo 7bb83606e * go/callgraph/rta: doc tweaks 7fa7e852d * cmd/digraph: somepath: search breadth-first to find minimal path d86c72936 * gopls/internal/lsp/source/completion: avoid duplicates from variants eaebeac4e * cmd/digraph: consolidate -help message and package doc ac255dec7 * go/analysis/passes/slog: replace XXXCtx names with XXXContext dfb7d247d * gopls/internal/lsp: make gopls.start_debugging open browser 8f0778217 * go/callgraph/rta: optimise 'implements' operation 4b177d0be * gopls/internal/lsp/filecache: increase idle GC period to 6 hours eaca1d005 * internal/pprof: a function to compute total pprof time 124ebfa4c * go/callgraph/rta: model reflective calls soundly 83045326b * go/packages: pass go list-reported Go language version to type checker f9f582ef3 * gopls/internal/lsp/source/completion: honor usePlaceholders e7916d015 * gopls/internal/lsp/source/completion: placeholders for type params 1d07f1ba5 * gopls/internal/regtest/marker: skip addgowork.txt 2d9070144 * gopls/internal/lsp/source/xrefs: include refs to methods of generics 8060af96a * gopls/internal/lsp/source: ignore objectpath error in rename a8cf665b1 * gopls: remove dead code eeb93eded * gopls/internal/lsp/cache: plumb analysis URLs to client 781c46759 * go.mod: update golang.org/x dependencies 675bf3c24 * go/ssa/interp: support conversions to slices of named bytes ad52c1ca3 * gopls/doc/contributing.md: document error handling strategies 14ec3c023 * go/packages/gopackages: document -mode flag c49536416 * gopls/internal/lsp/source/typerefs: move test into _test.go 87ad891fe * internal/fastwalk: doc formatting fixes (including godoc links) 27fd94e09 * gopls/internal/lsp/filecache: reduce GC frequency d362be0cd * Revert "go/analysis: add Sizes that matches gc size computations" 969078be4 * go/analysis: add Sizes that matches gc size computations 5aa6acb96 * go/vcs: delete 5a89a3bf2 * go/vcs: isolate into a nested module d03a819dc * go/vcs: deprecate package in favor of go list -json a6594121c * gopls/internal/lsp/cmd: list bug reports in 'gopls bug' 9d8d4089c * go/ast/inspector: clarify behavior regarding comment traversal 8f9bce43b * gopls/internal/lsp/cache: don't panic when import fails during analysis fa103593d * gopls/internal/lsp/cache: don't record edges to invalid packages c8278fe90 * cmd/godoc: disable TestWebIndex, a very slow test 87df9bcac * gopls/internal/lsp/cache: remove ITVs from shared import graph 63624dfc8 * gopls/internal/lsp/cache: fix nil panic in analysis toSourceDiagnostic 0ca9d30bb * gopls/internal/lsp/cache: add debugging assertion for golang/go#60904 85554d61b * gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID 9960b693c * gopls/internal/lsp/cache: use types.Unsafe in analysisPackage 6480332be * gopls/internal/lsp/work: don't crash when hovering over broken mod dir 155320d39 * gopls/internal/lsp/cache: reduce importing in analysis b71392afd * internal/gcimporter: avoid a crash when exporting a struct with no pkg d1a388b0e * cmd/digraph: add "to dot" to emit Graphviz dot a4ed05f16 * gopls/internal/regtest: fix goimports on windows when using vendoring 7261b3269 * gopls/internal/lsp/source/completion: ensuring completion completeness 41e4e5654 * go/ssa: fix bug in writeSignature on external functions ac2946029 * go/ssa: use core type within (*builder).receiver 3b62e7e25 * gopls/internal/lsp/cache: compute xrefs and methodsets asynchronously f394d451f * go.mod: update golang.org/x dependencies 27dbf8527 * go/types/objectpath: memoize scope lookup in objectpath.Encoder c6c983054 * gopls/internal/regtest/codelens: set GOWORK=off for go mod vendor 0245e1dfc * go/analysis/passes/defers: add analyser for defer mistake 85be8882c * cmd/digraph: improve examples using go list, mod c43232f86 * internal/gcimporter: treat unknown constant values the same as invalid 6e1595c15 * gopls/internal/lsp/cache: two minor simplifications c59d87f5d * go/packages/packagestest: set Config.Logf if the test is run verbosely db6a81ed1 * internal/typeparams: work around LookupFieldOrMethod inconsistency a01290f98 * gopls/internal/lsp/filecache: reduce lifespan of os.FileInfos 6f567c809 * gopls/internal/lsp: enable min/max builtin completion test 726c727df * gopls: unimported completion should use the completion matcher 86c93e873 * gopls/internal/lsp/source: fix panic in typeDefinition on comparable 04ceacbfb * gopls/internal/lsp/source/methodsets: comparable also has no package 947adca51 * gopls/internal/lsp/cache: add assertions c35c44fa0 * internal/diff: fix LineEdits bug in slow path 0b4461bab * internal/diff: fix LineEdits bug in fast path 1943c1e3e * go/pointer: delete package c6d86c4f3 * go/types/objectpath: remove unnecessary unsafe import 77fd064f3 * go/pointer: remove replace directive 0dda7d614 * gopls/internal/lsp/cache: check number of orphaned files after filtering 98f1b4dee * go/pointer: create submodule a260315e3 * cmd/{guru,callgraph}: stop using go/pointer 96844c359 * go/packages: include "unsafe".GoFiles=["unsafe.go"] cd694d8db * gopls/internal/lsp: add min/max builtin 33c741de7 * internal/lsp/source: use exact match in import highlighting 933c7ccb1 * gopls/internal/lsp: clear vuln diagnostics on config changes 5974258e6 * go/packages: pass -pgo=off on go1.21 and later f3faea198 * internal/lsp/debug: add links to profiles and GC 5f74ec7da * internal/diff: unexport various identifiers ed90c6d20 * gopls/internal/lsp/source: test references bug on struct{p.T} 827f5aa2c * go/ssa/interp: implement min/max builtins a12e1a6ae * gopls/internal/lsp/cache: remove nested module warning 9c97539a2 * gopls/internal/lsp/cmd: add a stats -anon flag to show anonymous data d44a094d8 * gopls/internal/lsp: bundle certain quick-fixes with their diagnostic e106694df * gopls/internal/lsp/filecache: reenable memory cache layer 5dc3f7433 * gopls/internal/lsp/cmd: simplify connection type 7e146a6c6 * gopls/internal/regtest/workspace: unskip duplicate modules test 1e6066861 * gopls/doc: Fix broken links 5ce721db5 * gopls/internal/lsp/cmd: remove vestiges of debugging golang/go#59475 7a03febee * gopls/internal/regtest/misc: update and unskip TestHoverIntLiteral a70f2bc21 * gopls/internal/regtest/misc: unskip TestMajorOptionsChange 6997d196f * gopls/internal/lsp/cache: fix crash in Session.updateViewLocked ec543c5a2 * gopls/internal/regtest/misc: update some unilaterally skipped tests a12ee94f7 * gopls: deprecate support for Go 1.16 and 1.17, update warnings 5ff5cbb00 * gopls/internal/lsp/cache: limit module scan to 100K files e6fd7f4c0 * gopls/internal/lsp/regtest: delete TestWatchReplaceTargets 9ca66ba88 * gopls/internal/lsp/source/completion: (unimported) add placeholders edbfdbebf * gopls: add a new "subdirWatchPatterns" setting 3a5dbf351 * internal/typesinternal: remove NewObjectpathFunc 3c0255176 * present: reformat doc comment for lack of inline code 07293620c * go/ssa: TestStdlib: disable check that function names are distinct d4e66bd9a * go/ssa: use core type for field accesses 738ea2bdc * gopls/internal/lsp: split file-watching glob patterns 2ec4299f3 * gopls/internal/lsp/cache: only delete the most relevant mod tidy handle 43b02eab0 * internal/lsp/filecache: eliminate 'kind' directories 5919673c9 * gopls/internal/lsp: keep track of overlays on the files map a5ef6c3eb * gopls/internal/lsp/mod: optimizations for mod tidy diagnostics d7f4359f8 * gopls/internal/lsp/filecache: touch only files older than 1h 2eb726b88 * gopls/internal/regtest/bench: add a benchmark for diagnosing saves b742cb9a5 * gopls/internal/lsp/cache: tweak error message 4d66324ee * gopls/internal/lsp/filecache: delayed tweaks from code review e46df400e * gopls/internal/lsp/debug: remove memory monitoring 3df69b827 * gopls/internal/lsp/filecache: avoid flock a069704d0 * gopls/internal/lsp/cache: fix race in adhoc reloading 3d53c2d20 * go/analysis/passes/slog: fix Group kv offset 8b4b27bce * cover: eliminate an unnecessary fsync in TestParseProfiles 242e5ed73 * go/ssa: fix typo in package docs 651d951bb * gopls/internal/lsp/debug: limit to 100 recent trace entries 743372f58 * go/ssa/interp: avoid hard-coding GOOS and GOARCH 522243a71 * gopls/internal/lsp/cache: fail workspace load on context cancellation a0593829f * gopls/internal/lsp/cache: unexport ValidBuildConfiguration e5c8d4db7 * go/ssa: use core type for composite literal addresses f4e8a711a * go/ssa: use core types for array length 3b25dbddd * gopls/internal/lsp/filecache: front with a 100MB in-memory LRU cache e7048d518 * gopls/internal/lsp/lru: extract LRU logic to a standalone package 8c0fcd2c6 * go/ssa/interp: use the actual GOOS and GOARCH to interpret tests 19d700c67 * gopls/internal/lsp/filecache: limit Get parallelism too 9dcd3d5dc * go/ssa: consolidate use of underlying pointer 7f203f0c3 * gopls/internal/lsp: add quick-fixes to manage the go.work file a13793e31 * internal/gcimporter: improve error handling 12a0517ad * gopls/internal/lsp/cache: call filecache.Set asynchronously 5eb1eb932 * gopls/internal/lsp/filecache: limit parallelism in Set 35fe77a6b * gopls: improve diagnostics for orphaned files 1c9fe3f82 * go/gcexportdata: drop support for the ancient binary format ad74ff634
myitcv
added a commit
to govim/govim
that referenced
this issue
Jul 19, 2023
* gopls/internal/lsp/cache: better panic if metadata invariant is broken 84f829e27 * gopls/internal/lsp/cache: frob: a fast encoder with gob-like powers 03275ec1a * gopls/internal/lsp: don't awaitLoaded inside resolveImportGraph dbfa51380 * gopls/internal/lsp: fix a latent bug in orphaned file reloading b16097183 * internal/facts: strength-reduce Package param to PackagePath 67aade56d * gopls/internal/lsp/source/typerefs: optimize getPackageHandles ffc82f3af * gopls/internal/lsp: only diagnose one package per file 50a6ef662 * internal/gcimporter: don't panic when exporting a builtin 'Error' method 48026e1f7 * gopls/protocol/generate: upgrade generating LSP stubs 5fed7a883 * gopls/internal/lsp/debug: display Analysis.Run times b9fd8df27 * gopls/internal: update LSP support 799eec0fd * gopls/internal/lsp/source: fix spurious "unexpected var object" error c6de5f512 * gopls/internal/regtest/bench: add a test simulating typing ba3c31c94 * gopls/internal/regtest/bench: add an 'oracle' benchmark repo 80c9aad95 * gopls/internal/regtest/bench: clean up profile flags e10bcf6a4 * go/types/internal/play: show enclosing scopes and method sets 50a7e142c * internal/typeparams: improve the panic in OriginMethod 12fe14902 * internal/gcimporter: supporting encoding objects from different packages 89d9fae1d * go/analysis: remove pointless comments dbd600188 * internal/gopathwalk: use opts.Logf for errors if set 67d73b296 * go/analysis: pass package's Go version to type checker 1ca21856a * gopls/internal/regtest/workspace: fix TestQuickFix_AddGoWork for go1.21 a721062d8 * internal/analysisutil: avoid IsNamed panic on built-in named types ba23fc4ab * go/analysis/passes/slog: unskip test e1d0f9142 * gopls: commands to start/stop profiling, and a new benchmark metric c35476fcc * internal/gopathwalk: use os.ReadFile instead of ioutil.ReadFile ec9bc5342 * internal/cmd/deadcode: a command to report dead code in Go programs aac7fb67a * gopls/internal/lsp/source: put context first in extracted functions 538a6e9ed * internal/lsp/analysis: embed directive analyzer check following decl ef1254549 * internal: fix typo 7bb83606e * go/callgraph/rta: doc tweaks 7fa7e852d * cmd/digraph: somepath: search breadth-first to find minimal path d86c72936 * gopls/internal/lsp/source/completion: avoid duplicates from variants eaebeac4e * cmd/digraph: consolidate -help message and package doc ac255dec7 * go/analysis/passes/slog: replace XXXCtx names with XXXContext dfb7d247d * gopls/internal/lsp: make gopls.start_debugging open browser 8f0778217 * go/callgraph/rta: optimise 'implements' operation 4b177d0be * gopls/internal/lsp/filecache: increase idle GC period to 6 hours eaca1d005 * internal/pprof: a function to compute total pprof time 124ebfa4c * go/callgraph/rta: model reflective calls soundly 83045326b * go/packages: pass go list-reported Go language version to type checker f9f582ef3 * gopls/internal/lsp/source/completion: honor usePlaceholders e7916d015 * gopls/internal/lsp/source/completion: placeholders for type params 1d07f1ba5 * gopls/internal/regtest/marker: skip addgowork.txt 2d9070144 * gopls/internal/lsp/source/xrefs: include refs to methods of generics 8060af96a * gopls/internal/lsp/source: ignore objectpath error in rename a8cf665b1 * gopls: remove dead code eeb93eded * gopls/internal/lsp/cache: plumb analysis URLs to client 781c46759 * go.mod: update golang.org/x dependencies 675bf3c24 * go/ssa/interp: support conversions to slices of named bytes ad52c1ca3 * gopls/doc/contributing.md: document error handling strategies 14ec3c023 * go/packages/gopackages: document -mode flag c49536416 * gopls/internal/lsp/source/typerefs: move test into _test.go 87ad891fe * internal/fastwalk: doc formatting fixes (including godoc links) 27fd94e09 * gopls/internal/lsp/filecache: reduce GC frequency d362be0cd * Revert "go/analysis: add Sizes that matches gc size computations" 969078be4 * go/analysis: add Sizes that matches gc size computations 5aa6acb96 * go/vcs: delete 5a89a3bf2 * go/vcs: isolate into a nested module d03a819dc * go/vcs: deprecate package in favor of go list -json a6594121c * gopls/internal/lsp/cmd: list bug reports in 'gopls bug' 9d8d4089c * go/ast/inspector: clarify behavior regarding comment traversal 8f9bce43b * gopls/internal/lsp/cache: don't panic when import fails during analysis fa103593d * gopls/internal/lsp/cache: don't record edges to invalid packages c8278fe90 * cmd/godoc: disable TestWebIndex, a very slow test 87df9bcac * gopls/internal/lsp/cache: remove ITVs from shared import graph 63624dfc8 * gopls/internal/lsp/cache: fix nil panic in analysis toSourceDiagnostic 0ca9d30bb * gopls/internal/lsp/cache: add debugging assertion for golang/go#60904 85554d61b * gopls/internal/lsp/cache: guard against "unsafe" by package path, not ID 9960b693c * gopls/internal/lsp/cache: use types.Unsafe in analysisPackage 6480332be * gopls/internal/lsp/work: don't crash when hovering over broken mod dir 155320d39 * gopls/internal/lsp/cache: reduce importing in analysis b71392afd * internal/gcimporter: avoid a crash when exporting a struct with no pkg d1a388b0e * cmd/digraph: add "to dot" to emit Graphviz dot a4ed05f16 * gopls/internal/regtest: fix goimports on windows when using vendoring 7261b3269 * gopls/internal/lsp/source/completion: ensuring completion completeness 41e4e5654 * go/ssa: fix bug in writeSignature on external functions ac2946029 * go/ssa: use core type within (*builder).receiver 3b62e7e25 * gopls/internal/lsp/cache: compute xrefs and methodsets asynchronously f394d451f * go.mod: update golang.org/x dependencies 27dbf8527 * go/types/objectpath: memoize scope lookup in objectpath.Encoder c6c983054 * gopls/internal/regtest/codelens: set GOWORK=off for go mod vendor 0245e1dfc * go/analysis/passes/defers: add analyser for defer mistake 85be8882c * cmd/digraph: improve examples using go list, mod c43232f86 * internal/gcimporter: treat unknown constant values the same as invalid 6e1595c15 * gopls/internal/lsp/cache: two minor simplifications c59d87f5d * go/packages/packagestest: set Config.Logf if the test is run verbosely db6a81ed1 * internal/typeparams: work around LookupFieldOrMethod inconsistency a01290f98 * gopls/internal/lsp/filecache: reduce lifespan of os.FileInfos 6f567c809 * gopls/internal/lsp: enable min/max builtin completion test 726c727df * gopls: unimported completion should use the completion matcher 86c93e873 * gopls/internal/lsp/source: fix panic in typeDefinition on comparable 04ceacbfb * gopls/internal/lsp/source/methodsets: comparable also has no package 947adca51 * gopls/internal/lsp/cache: add assertions c35c44fa0 * internal/diff: fix LineEdits bug in slow path 0b4461bab * internal/diff: fix LineEdits bug in fast path 1943c1e3e * go/pointer: delete package c6d86c4f3 * go/types/objectpath: remove unnecessary unsafe import 77fd064f3 * go/pointer: remove replace directive 0dda7d614 * gopls/internal/lsp/cache: check number of orphaned files after filtering 98f1b4dee * go/pointer: create submodule a260315e3 * cmd/{guru,callgraph}: stop using go/pointer 96844c359 * go/packages: include "unsafe".GoFiles=["unsafe.go"] cd694d8db * gopls/internal/lsp: add min/max builtin 33c741de7 * internal/lsp/source: use exact match in import highlighting 933c7ccb1 * gopls/internal/lsp: clear vuln diagnostics on config changes 5974258e6 * go/packages: pass -pgo=off on go1.21 and later f3faea198 * internal/lsp/debug: add links to profiles and GC 5f74ec7da * internal/diff: unexport various identifiers ed90c6d20 * gopls/internal/lsp/source: test references bug on struct{p.T} 827f5aa2c * go/ssa/interp: implement min/max builtins a12e1a6ae * gopls/internal/lsp/cache: remove nested module warning 9c97539a2 * gopls/internal/lsp/cmd: add a stats -anon flag to show anonymous data d44a094d8 * gopls/internal/lsp: bundle certain quick-fixes with their diagnostic e106694df * gopls/internal/lsp/filecache: reenable memory cache layer 5dc3f7433 * gopls/internal/lsp/cmd: simplify connection type 7e146a6c6 * gopls/internal/regtest/workspace: unskip duplicate modules test 1e6066861 * gopls/doc: Fix broken links 5ce721db5 * gopls/internal/lsp/cmd: remove vestiges of debugging golang/go#59475 7a03febee * gopls/internal/regtest/misc: update and unskip TestHoverIntLiteral a70f2bc21 * gopls/internal/regtest/misc: unskip TestMajorOptionsChange 6997d196f * gopls/internal/lsp/cache: fix crash in Session.updateViewLocked ec543c5a2 * gopls/internal/regtest/misc: update some unilaterally skipped tests a12ee94f7 * gopls: deprecate support for Go 1.16 and 1.17, update warnings 5ff5cbb00 * gopls/internal/lsp/cache: limit module scan to 100K files e6fd7f4c0 * gopls/internal/lsp/regtest: delete TestWatchReplaceTargets 9ca66ba88 * gopls/internal/lsp/source/completion: (unimported) add placeholders edbfdbebf * gopls: add a new "subdirWatchPatterns" setting 3a5dbf351 * internal/typesinternal: remove NewObjectpathFunc 3c0255176 * present: reformat doc comment for lack of inline code 07293620c * go/ssa: TestStdlib: disable check that function names are distinct d4e66bd9a * go/ssa: use core type for field accesses 738ea2bdc * gopls/internal/lsp: split file-watching glob patterns 2ec4299f3 * gopls/internal/lsp/cache: only delete the most relevant mod tidy handle 43b02eab0 * internal/lsp/filecache: eliminate 'kind' directories 5919673c9 * gopls/internal/lsp: keep track of overlays on the files map a5ef6c3eb * gopls/internal/lsp/mod: optimizations for mod tidy diagnostics d7f4359f8 * gopls/internal/lsp/filecache: touch only files older than 1h 2eb726b88 * gopls/internal/regtest/bench: add a benchmark for diagnosing saves b742cb9a5 * gopls/internal/lsp/cache: tweak error message 4d66324ee * gopls/internal/lsp/filecache: delayed tweaks from code review e46df400e * gopls/internal/lsp/debug: remove memory monitoring 3df69b827 * gopls/internal/lsp/filecache: avoid flock a069704d0 * gopls/internal/lsp/cache: fix race in adhoc reloading 3d53c2d20 * go/analysis/passes/slog: fix Group kv offset 8b4b27bce * cover: eliminate an unnecessary fsync in TestParseProfiles 242e5ed73 * go/ssa: fix typo in package docs 651d951bb * gopls/internal/lsp/debug: limit to 100 recent trace entries 743372f58 * go/ssa/interp: avoid hard-coding GOOS and GOARCH 522243a71 * gopls/internal/lsp/cache: fail workspace load on context cancellation a0593829f * gopls/internal/lsp/cache: unexport ValidBuildConfiguration e5c8d4db7 * go/ssa: use core type for composite literal addresses f4e8a711a * go/ssa: use core types for array length 3b25dbddd * gopls/internal/lsp/filecache: front with a 100MB in-memory LRU cache e7048d518 * gopls/internal/lsp/lru: extract LRU logic to a standalone package 8c0fcd2c6 * go/ssa/interp: use the actual GOOS and GOARCH to interpret tests 19d700c67 * gopls/internal/lsp/filecache: limit Get parallelism too 9dcd3d5dc * go/ssa: consolidate use of underlying pointer 7f203f0c3 * gopls/internal/lsp: add quick-fixes to manage the go.work file a13793e31 * internal/gcimporter: improve error handling 12a0517ad * gopls/internal/lsp/cache: call filecache.Set asynchronously 5eb1eb932 * gopls/internal/lsp/filecache: limit parallelism in Set 35fe77a6b * gopls: improve diagnostics for orphaned files 1c9fe3f82 * go/gcexportdata: drop support for the ancient binary format ad74ff634
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This was reported in #60551 (comment), but I think is a separate bug (in the ordinary type checking, not analysis component:
2023/06/13 10:49:34 computing the shared import graph: import failed for "vendor/golang.org/x/crypto/chacha20poly1305": internal error while importing "vendor/golang.org/x/crypto/chacha20poly1305" (conflicting names chacha20poly1305 and server for package "vendor/golang.org/x/crypto/chacha20poly1305"); please report an issue
I wonder whether we're making spurious hits in an ID or PackagePath-keyed import map because the current package is called "command-line-arguments"?
The text was updated successfully, but these errors were encountered: