Skip to content

x/build/cmd/watchflakes: fails to attribute *** Test killed with quit: failures to the running test #61070

Open
@bcmills

Description

@bcmills

In #57995 (comment), I see a test failure ending in:

*** Test killed with quit: ran too long (4m0s).
FAIL	bytes	240.041s

but watchflakes matched that to the explicit condition test == "" .

This pattern should be fairly easy to match, so watchflakes should attribute these failures to the correct package's tests.

(attn @cherrymui)

Activity

added
Buildersx/build issues (builders, bots, dashboards)
on Jun 29, 2023
added this to the Unreleased milestone on Jun 29, 2023
bcmills

bcmills commented on Jun 29, 2023

@bcmills
ContributorAuthor

Hrm, and then when I excluded Test killed with quit from #57995, watchflakes filed #61071 with the correct package path.

So maybe the bug here is that test == "" incorrectly matches failures that have a non-empty test?

added
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
on Jun 30, 2023
cagedmantis

cagedmantis commented on Jun 30, 2023

@cagedmantis
Contributor

/cc @golang/release for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @cagedmantis@bcmills@gopherbot

        Issue actions

          x/build/cmd/watchflakes: fails to attribute `*** Test killed with quit:` failures to the running test · Issue #61070 · golang/go