-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Closed
Labels
Buildersx/build issues (builders, bots, dashboards)x/build issues (builders, bots, dashboards)FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.
Milestone
Description
https://go.dev/cl/517755 caused a compilation error on the plan9
builders (https://build.golang.org/log/2613479c07e3aaf02e75f15f00b8d1c01c9ec217):
# os_test [os.test]
os/os_test.go:3297:70: too many arguments in call to syscall.Open
have (string, number, number)
want (string, int)
os/os_test.go:3302:55: too many arguments in call to syscall.Open
have (string, number, number)
want (string, int)
FAIL os [build failed]
I didn't catch that during code review because the CL had a passing TryBot run, and based on #20119 I assumed that the misc-compile
TryBots would have caught any compile error in the test.
It appears that either the fix for #20119 was incomplete, or something has regressed since then to cause the misc-compile
TryBots to no longer catch compile errors in tests.
(CC @dmitshur @aclements @golang/release)
Metadata
Metadata
Assignees
Labels
Buildersx/build issues (builders, bots, dashboards)x/build issues (builders, bots, dashboards)FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.
Type
Projects
Status
Done