Skip to content

x/telemetry/upload: convert old counter files to local report files #62619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyangah opened this issue Sep 13, 2023 · 1 comment
Closed

x/telemetry/upload: convert old counter files to local report files #62619

hyangah opened this issue Sep 13, 2023 · 1 comment
Assignees
Labels
FrozenDueToAge telemetry x/telemetry issues
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 13, 2023

Currently, if a counter file is more than 21 days old, the uploader deletes the file without converting it to local report.
That can leave a mysterious gap in the local telemetry viewer. It will be hard to tell whether there were no counters collected or the uploader ran too late. Let's keep converting the file to the local json report before deletion.

I think removing https://go.googlesource.com/telemetry/+/refs/heads/master/internal/upload/reports.go#49 is sufficient.
https://go.googlesource.com/telemetry/+/refs/heads/master/internal/upload/reports.go#119 is already preventing upload of too old counters.

@gopherbot gopherbot added the telemetry x/telemetry issues label Sep 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Sep 13, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/528296 mentions this issue: internal/upload: generate local report for obsolete count files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

3 participants