internal/upload: generate local report for obsolete count files

The existing code silently removed count files that were too old to
use. Now it generates a local report. It still does not generate an
upload report.

Fixes: golang/go#62619
Change-Id: Ic1a68e323626e2defd233316769d3ab89933d66f
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/528296
Run-TryBot: Peter Weinberger <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Author: pjweinbgo

internal/upload/dates_test.go

@@ -54,7 +54,8 @@ func TestDates(t *testing.T) {
 			date:   "2020-01-01",
 			begins: "2020-01-01",
 			ends:   olderThan(t, today, distantPast, "oldcountfile"),
-			// locals, readys, uploads are empty, and there should be nothing left
+			// one local; readys, uploads are empty, and there should be nothing left
+			wantLocal: 1,
 		},
 		{ // test that a count file expiring today is left alone
 			name:       "todayscountfile",
@@ -113,7 +114,6 @@ func TestDates(t *testing.T) {
 		}
 		used[tx.name] = tx.name
 		used[tx.date] = tx.name
-		log.Printf("doing %s", tx.name)
 		doTest(t, &tx, cs)
 	}
 }

internal/upload/reports.go

@@ -43,8 +43,8 @@ func reports(todo *work) ([]string, error) {
 		}
 	}
 	for k, v := range countFiles {
-		if notNeeded(k, *todo) || tooOld(k) {
-			// Too old, or the report already exists.
+		if notNeeded(k, *todo) {
+			// The report already exists.
 			// There's another check in createReport.
 			deleteFiles(v)
 			continue