Skip to content

x/tools/gopls: match new language versions for type checking #63472

Closed
@findleyr

Description

@findleyr

Just spotted this bug: https://cs.opensource.google/go/x/tools/+/master:gopls/internal/lsp/cache/check.go;l=1490;drc=6de34480a867b1198bb6c910cb77c147e89a6023

We need to update goVersionRx to allow for e.g. go1.21.1. As is, it looks like we'll be setting the wrong language version for the new version strings.

Activity

added
goplsIssues related to the Go language server, gopls.
ToolsThis label describes issues relating to any tools in the x/tools repository.
on Oct 9, 2023
added this to the gopls/v0.14.0 milestone on Oct 9, 2023
findleyr

findleyr commented on Oct 13, 2023

@findleyr
MemberAuthor

This is harmless until 1.22 comes out, because the default behavior of the type checker is to allow all features.

gopherbot

gopherbot commented on Jan 19, 2024

@gopherbot
Contributor

Change https://go.dev/cl/557215 mentions this issue: gopls/internal/lsp/cache: allow versions of form "go1.2.3"

added a commit that references this issue on Feb 5, 2024
cd7b510
locked and limited conversation to collaborators on Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @adonovan@gopherbot@findleyr

      Issue actions

        x/tools/gopls: match new language versions for type checking · Issue #63472 · golang/go