Skip to content

cmd/go: flag modcacherw does not take effect in the target package [1.21 backport] #64497

Closed
@gopherbot

Description

@gopherbot

@bcmills requested issue #64282 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This was a regression in Go 1.21 and has no clear workaround.

Activity

added this to the Go1.21.5 milestone on Dec 1, 2023
bcmills

bcmills commented on Dec 1, 2023

@bcmills
Contributor

The fix for this seems straightforward and poses almost no risk to code outside of go install pkg@version and go run pkg@version. Approving for backport.

modified the milestones: Go1.21.5, Go1.21.6 on Dec 5, 2023
gopherbot

gopherbot commented on Dec 14, 2023

@gopherbot
ContributorAuthor

Change https://go.dev/cl/550055 mentions this issue: [release-branch.go1.21] cmd/go/internal/toolchain: make a best effort to parse 'go run' and 'go install' flags

thanm

thanm commented on Dec 19, 2023

@thanm
Contributor

Note: the fix for this issue on master was reverted in CL 551215, so we'll need to decide what to do with this issue.

modified the milestones: Go1.21.6, Go1.21.7 on Jan 9, 2024
added
WaitingForInfoIssue is not actionable because of missing required information, which needs to be provided.
on Jan 25, 2024
removed
WaitingForInfoIssue is not actionable because of missing required information, which needs to be provided.
on Jan 29, 2024
gopherbot

gopherbot commented on Jan 29, 2024

@gopherbot
ContributorAuthor

Change https://go.dev/cl/559198 mentions this issue: [release-branch.go1.21] cmd/go/internal/toolchain: apply the -modcacherw flag when downloading a module to determine what toolchain it needs

gopherbot

gopherbot commented on Jan 31, 2024

@gopherbot
ContributorAuthor

Closed by merging 6552f3d to release-branch.go1.21.

added a commit that references this issue on Jan 31, 2024
6552f3d
locked and limited conversation to collaborators on Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bcmills@gopherbot@thanm@cherrymui

        Issue actions

          cmd/go: flag modcacherw does not take effect in the target package [1.21 backport] · Issue #64497 · golang/go