Skip to content

x/tools/gopls: support "inline all" and "inline away" #66370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
findleyr opened this issue Mar 18, 2024 · 1 comment
Open

x/tools/gopls: support "inline all" and "inline away" #66370

findleyr opened this issue Mar 18, 2024 · 1 comment
Assignees
@findleyr
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.20.0

Comments

@findleyr
Copy link
Member

findleyr commented Mar 18, 2024 •
edited
Loading

Add two new code actions for inlining, defined at the callee rather than caller:

  • "inline all" inlines all uses of a function
  • "inline away" inlines all uses, and additionally removes the function declaration
@findleyr findleyr self-assigned this Mar 18, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 18, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Mar 18, 2024
@findleyr findleyr added FeatureRequest Issues asking for a new feature that does not need a proposal. Refactoring Issues related to refactoring tools labels Mar 18, 2024
@adonovan adonovan mentioned this issue Mar 22, 2024
Closed
@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 May 23, 2024
@adonovan
Copy link
Member

adonovan commented Nov 10, 2024 •
edited
Loading

See also:

@adonovan adonovan modified the milestones: gopls/v0.17.0, gopls/v0.18.0 Nov 10, 2024
@findleyr findleyr modified the milestones: gopls/v0.18.0, gopls/v0.19.0 Feb 7, 2025
This was referenced Feb 12, 2025
Open
Open
@findleyr findleyr modified the milestones: gopls/v0.19.0, gopls/v0.20.0 Apr 24, 2025
@adonovan adonovan modified the milestones: gopls/v0.20.0, gopls/backlog Apr 24, 2025
@adonovan adonovan mentioned this issue May 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.20.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr