Skip to content

x/build/cmd/watchflakes: shouldn't reopen frozen issues #67232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue May 7, 2024 · 2 comments
Closed

x/build/cmd/watchflakes: shouldn't reopen frozen issues #67232

dmitshur opened this issue May 7, 2024 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Member

dmitshur commented May 7, 2024 •
edited
Loading

It can be pretty confusing if watchflakes is willing to reopen an issue so old that it is frozen. It should probably opt to file a new issue instead in such cases (and optionally refer to the frozen one).

This happened in #56707, which was a frozen issue in Go1.20 milestone with Soon label that got reopened.

Related issues:
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest Issues asking for a new feature that does not need a proposal. labels May 7, 2024
@dmitshur dmitshur added this to the Unreleased milestone May 7, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 7, 2024
@dmitshur dmitshur mentioned this issue May 7, 2024
Closed
@cherrymui
Copy link
Member

@dmitshur now that we auto-evict old issues from the Test Flakes project, watchflakes shouldn't see frozen issues. Is there anything else needed for this? We could still explicitly not reopen frozen issues, but it doesn't seem very necessary?

@dmitshur
Copy link
Member Author

dmitshur commented Jul 25, 2024 •
edited
Loading

I agree, the auto-archival of closed issues without recent activity likely removes the main source of this happening. Let's not do anything for now unless we find out this is still a problem somehow. Thanks.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @cherrymui