Skip to content

x/tools/gopls: analysis crash analyzing new uses of go1.23 range iterators #67237

Closed
@adonovan

Description

@adonovan

@ianlancetaylor reports that gopls crashes in the buildir analyzer (which is staticcheck's fork of go/ssa and buildssa) when it encounters a range-over-func statement in new code he is trying to merge the to the std slices package. The ir package doesn't yet support range-over-func. Nor does go/ssa (but see https://go.dev/cl/555075).

As a matter of priority, we need to disable ssa- and ir-based analyzers on packages that use range-over-func. Then we need to fix these packages before go1.23.

Activity

self-assigned this
on May 7, 2024
added
ToolsThis label describes issues relating to any tools in the x/tools repository.
goplsIssues related to the Go language server, gopls.
on May 7, 2024
added
gopls/analysisIssues related to running analysis in gopls
and removed
goplsIssues related to the Go language server, gopls.
ToolsThis label describes issues relating to any tools in the x/tools repository.
on May 7, 2024
added this to the Unreleased milestone on May 7, 2024
dominikh

dominikh commented on May 7, 2024

@dominikh
Member

Relevant Staticcheck issue: dominikh/go-tools#1494

gopherbot

gopherbot commented on May 7, 2024

@gopherbot
Contributor

Change https://go.dev/cl/583778 mentions this issue: gopls/internal/analysis: disable ssa/ir analyzers on range-over-func

6 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @dominikh@adonovan@gopherbot

      Issue actions

        x/tools/gopls: analysis crash analyzing new uses of go1.23 range iterators · Issue #67237 · golang/go