Skip to content

x/build/cmd/golangbuild: wrapped command invocation is broken on Windows #68310

Closed
@dmitshur

Description

@dmitshur

The latest version of golangbuild fails to correctly wrap the "go test" invocation with "rdb.exe stream". The result is that instead of "rdb.exe", "go.exe" is being invoked instead. For example, see https://ci.chromium.org/b/8743332564145763297:

C:\b\s\w\ir\cache\tools\bin\rdb.exe stream -var goos:windows -var goarch:amd64 -var host_goos:windows -var host_goarch:amd64 -var builder:x_debug-gotip-windows-amd64 -var go_branch:master -tag bootstrap_version:1.20.6 -tag swarming_bot_id:golang-tryw-win10-us-west1-b-0-85le -- C:\b\s\w\ir\cache\tools\bin\result_adapter.exe go -v=false -dump-json C:\b\s\w\ir\x\w\go.testjson -- C:\b\s\w\ir\x\w\goroot\bin\go test -json -short ./...

go stream: unknown command
Run 'go help' for usage.

The change in CL 581695 for issue #66586 is a plausible culprit.

Metadata

Metadata

Assignees

Labels

Buildersx/build issues (builders, bots, dashboards)FixPendingIssues that have a fix which has not yet been reviewed or submitted.NeedsFixThe path to resolution is known, but the work has not been done.OS-WindowsSoonThis needs action soon. (recent regressions, service outages, unusual time-sensitive situations)

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions