Skip to content

x/telemetry/config: collect gopls/telemetryprompt/accepted #68770

Closed
@findleyr

Description

@findleyr

Summary

From gopls, we ask a select fraction of users to enable telemetry via an LSP prompt (a showMessageRequest dialog). Starting in gopls@v0.16.1, we record a gopls/telemetryprompt/accepted counter when users accept the prompt.

By collecting this counter, we can estimate the fraction of new telemetry participants that are coming from the prompt, which will help us evaluate the efficacy of the prompt itself.

Of course, we cannot know how many users decline the prompt.

Proposed Config Change

https://go.dev/cl/603936

Activity

added this to the Unreleased milestone on Aug 7, 2024
gabyhelp

gabyhelp commented on Aug 7, 2024

@gabyhelp
findleyr

findleyr commented on Aug 9, 2024

@findleyr
MemberAuthor

It occurred to me that because we have a conservative cutoff, we won't ever upload the counter file for the day that telemetry is enabled: we only upload counter files that do not overlap with any period of time when telemetry uploading was not enabled.

Therefore, I think gopls should record at every startup whether the prompt was accepted. Theoretically, we could also record other prompt outcomes: some users may decline the prompt but enable telemetry via other means.

Putting this in the gopls@v0.16.2 milestone to address the collection issue.

added
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
on Aug 12, 2024
cagedmantis

cagedmantis commented on Aug 12, 2024

@cagedmantis
Contributor
gopherbot

gopherbot commented on Aug 14, 2024

@gopherbot
Contributor

Change https://go.dev/cl/603936 mentions this issue: internal/chartconfig: add collection for gopls/telemetryprompt/accepted

gopherbot

gopherbot commented on Aug 22, 2024

@gopherbot
Contributor

Change https://go.dev/cl/607758 mentions this issue: gopls: increment the telemetryprompt acceptance counter for each session

gopherbot

gopherbot commented on Aug 28, 2024

@gopherbot
Contributor

Change https://go.dev/cl/609135 mentions this issue: [gopls-release-branch.0.16] gopls: increment the telemetryprompt acceptance counter for each session

added a commit that references this issue on Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Telemetry-AcceptedTelemetry-ProposalIssues proposing new telemetry counters.telemetryx/telemetry issues

    Type

    No type

    Projects

    Status

    No status

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @cagedmantis@hyangah@gopherbot@findleyr@gabyhelp

        Issue actions

          x/telemetry/config: collect gopls/telemetryprompt/accepted · Issue #68770 · golang/go