x/tools/gopls: DidModifyFiles: "failed to define view for open file" bug in selectViewDefs

[adonovan]

#!stacks
"bug.Errorf" && "selectViewDefs:+67"

Issue created by stacks.

		def, err = defineView(ctx, fs, folder, fh)
		if err != nil {
			// We should never call selectViewDefs with a cancellable context, so
			// this should never fail.
			return nil, bug.Errorf("failed to define view for open file: %v", err)
		}

This stack TUHRvQ was reported by telemetry:

• gopls/bug
• golang.org/x/tools/gopls/internal/util/bug.report:+35
• golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
• golang.org/x/tools/gopls/internal/cache.selectViewDefs:+67
• golang.org/x/tools/gopls/internal/cache.(*Session).DidModifyFiles:+93
• golang.org/x/tools/gopls/internal/server.(*server).didModifyFiles:+36
• golang.org/x/tools/gopls/internal/server.(*server).DidChangeWatchedFiles:+13
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+634
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
• golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
• golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: "unexpected file: %q" bug.Report in bestView (reported by telemetry) #67288
• x/tools/gopls: "finding best view for change" bug.Report in Session.DidModifyFiles (via telemetry) #67144 (closed)
• x/tools/gopls: DidModifyFiles: "non-abs file path %q" bug in port.matches #70603
• x/tools/gopls: crash in View.Options #61325 (closed)
• x/tools/gopls: ApplyFix: "no file for edit position" bug in suggestedFixToDocumentChange (via telemetry) #68818
• x/tools/gopls: "addView called before server initialized" #57459 (closed)
• x/tools/gopls: Hover: nil deref in parseDocLink #70635 (closed)
• x/tools/gopls: "inline: corrupted reference %v" bug in golang.RemoveUnusedParameter #69896 (closed)
• x/tools/gopls: panic handling invalid directoryFilters setting #51843 (closed)
• x/tools/gopls: bug: load.go:185: go/packages returned unexpected package "golang.org/x/tools/go/callgraph/cha/testdata/iface.go.master" for standalone file #69331 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/639435 mentions this issue: gopls/internal/cache: remove overzealous bug.Report