Skip to content

x/tools/gopls: out-of-memory failure on Windows #71065

Open
@adonovan

Description

@adonovan
#!stacks
"runtime.bgsweep" && "runtime.newArenaMayUnlock:+6" && "runtime.throw"

Issue created by stacks.

I suspect this is another manifestation of #70445, but I thought I should report it since the call stack is completely different.

This stack F860lA was reported by telemetry:

golang.org/x/tools/gopls@v0.17.1 go1.23.4 windows/amd64 vscode (1)

Activity

added
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
goplsIssues related to the Go language server, gopls.
ToolsThis label describes issues relating to any tools in the x/tools repository.
on Dec 30, 2024
mknyszek

mknyszek commented on Jan 15, 2025

@mknyszek
Contributor

This just seems like a regular OOM. On Windows all system-allocated memory must be committed up-front, so syscalls actually start failing (unlike Linux, where page faults try to page in more physical memory and that's the signal). So, it's impossible to tell from this whether the OOM is due to the person running gopls just ate up their own memory with various apps or gopls was using too much memory, unfortunately. But we don't think this is a bug in the runtime.

changed the title [-]runtime: fatal "cannot allocate memory" throw in bgsweep goroutine (windows)[/-] [+]gopls: out-of-memory failure on Windows[/+] on Jan 15, 2025
changed the title [-]gopls: out-of-memory failure on Windows[/-] [+]x/tools/gopls: out-of-memory failure on Windows[/+] on Jan 15, 2025
added this to the Unreleased milestone on Jan 15, 2025
findleyr

findleyr commented on Jan 16, 2025

@findleyr
Member

Keeping this open but moving to the backlog, since it is currently unactionable.
(I'd close it, but absent other mechanisms to track OOMs, let's keep recording stacks here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.gopls/telemetry-wins

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mknyszek@adonovan@gopherbot@findleyr@gabyhelp

        Issue actions

          x/tools/gopls: out-of-memory failure on Windows · Issue #71065 · golang/go