x/tools/gopls: "missing reference to package %s" bug in getOneTransitiveRefLocked

[adonovan]

#!stacks
"bug.Reportf" && "getOneTransitiveRefLocked:+32"

Issue created by stacks.

	// Note that if (!ok && trefs.complete), the name does not exist in the
	// referenced package, and we should not write to trefs as that may introduce
	// a race.
	if !ok && !trefs.complete {
		n := b.nodes[sym.Package]
		if n == nil {
			// We should always have IndexID in our node set, because symbol references
			// should only be recorded for packages that actually exist in the import graph.
			//
			// However, it is not easy to prove this (typerefs are serialized and
			// deserialized), so make this code temporarily defensive while we are on a
			// point release.
			//
			// TODO(rfindley): in the future, we should turn this into an assertion.
			bug.Reportf("missing reference to package %s", b.s.view.pkgIndex.PackageID(sym.Package)) <---- here
			return nil
		}

This stack vcyB-g was reported by telemetry:

• gopls/bug
• golang.org/x/tools/gopls/internal/util/bug.report:+35
• golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
• golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).getOneTransitiveRefLocked:+32
• golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).getTransitiveRefs:+22
• golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle:+129
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles.func2.1:+8
• golang.org/x/sync/errgroup.(*Group).Go.func1:+3
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.17.1 go1.23.2 linux/amd64 vscode (2)

[gabyhelp]

Related Issues

• x/tools/gopls: "missing reachable node for %q" bug in evaluatePackageHandle #71352
• x/tools/gopls: crash in packageReferences (reported by telemetry) #66250 (closed)
• x/tools/gopls: bug reported by telemetry [qoVPwQ] #64243 (closed)
• x/tools/gopls: "package name is %q, want %q" bug in typeCheckBatch.importPackage #64235
• x/tools/gopls: "nil handle" assert in getPackageHandles #71353
• x/tools/gopls: "go/packages failed to return non-test standalone package" bug (reported by telemetry) #66204 (closed)
• x/tools/gopls: limited cross references when using with vscode on Go repo #41633 (closed)
• x/tools/gopls: "go/packages returned unexpected package %q for standalone file" bug in Snapshot.load #69895 (closed)
• x/tools/gopls: bug in analysis importer reported by telemetry #64236 (closed)
• x/tools/gopls: nil deref in evaluatePackageHandle (telemetry) #69236 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}