x/tools/gopls: Rename: type assertion panics in renameImports

[adonovan]

#!stacks
"panicdottypeI" && "renameImports:+83"

Issue created by stacks.

		for _, imp := range f.File.Imports {
				if imp.Name != nil {
					continue // has explicit local name
				}
				if rdeps[id].DepsByImpPath[metadata.UnquoteImportPath(imp)] != mp.ID {
					continue // not the import we're looking for
				}

				pkgname := pkg.TypesInfo().Implicits[imp].(*types.PkgName) // <---- panicdottypeI here

This stack SRoMsA was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• runtime.panicdottypeE:=275
• runtime.panicdottypeI:+5
• golang.org/x/tools/gopls/internal/golang.renameImports:+83
• golang.org/x/tools/gopls/internal/golang.renamePackage:+75
• golang.org/x/tools/gopls/internal/golang.renamePackageName:+2
• golang.org/x/tools/gopls/internal/golang.Rename:+22
• golang.org/x/tools/gopls/internal/server.(*server).Rename:+17
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+489
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
• golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
• golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.17.1 go1.23.4 linux/amd64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: Rename: crash due to Info.Defs[id]=nil bug in checkStructField #70968
• x/tools/gopls: "edit does not belong to syntax of package %q" bug in golang.Rename #70049
• x/tools/gopls: crash when renaming in a package using builtins with type parameters #52940 (closed)
• x/tools/gopls: Rename: "unexpected composite literal type %T: %v" panic in satisfy.(*Finder).Find #71538
• x/tools/gopls: Rename: "no type for %T" panic in satisfy #71572
• x/tools/gopls: rename crashes on single segment import path #33768 (closed)
• x/tools/gopls: completion: failed type assertion in inferExpectedTypeArg #70889 (closed)
• x/tools/internal/refactor/inline: panic in needsParens #71486 (closed)
• x/tools/gopls: rename crashes in objectpath #60789 (closed)
• x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr #71657

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}