x/tools/gopls: "Browse gopls feature documentation" has higher priority than "Add import" #72742
Labels
Documentation
Issues describing a change to documentation.
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
your-diary
added
gopls
gabyhelp
added
the
ToolProposal
|
Another supported field in LSP of returned code action is See LSP |
jba
removed
the
ToolProposal
|
Change https://go.dev/cl/662915 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
gopls version
go env
What did you do?
Open
main.gobelow. Notefmtpackage is not imported.Move the cursor to the top of
fmtkeyword.Open the code actions panel to use
Add importfunctionality ofgopls.What did you see happen?
Browse gopls feature documentationhas higher priority thanAdd import.What did you expect to see?
I believe, in older versions,
Add importhad higher priority. (Maybe related or not related: golang/vscode-go #3498)So
At least I want to change the order to make
Add importthe top action. Unintentionally selectingBrowse gopls feature documentationopens a new window, which is very annoying (in terms of context switching etc.)If possible, I want even to disable
Browse gopls feature documentationcompletely. I never use it.Editor and settings
I'm using Vim and
coc.nvimplugin and set up the vanillagoplsin:CocConfigas suggested by thecoc.nvimteam:{ "languageserver": { "golang": { "command": "gopls", "rootPatterns": [ "go.mod" ], "filetypes": [ "go" ] } } }(I don't use plugins like
vim-goorcoc-go.)Logs
Using the debug mode of
coc.nvim(this and this), I captured the output ofgoplswhen I opened the code actions panel (textDocument/codeAction).We can see
Browse gopls feature documentationis returned as the first element of the array.Request
{ "textDocument": { "uri": "file:///Users/user/a/main.go" }, "range": { "start": { "line": 3, "character": 2 }, "end": { "line": 3, "character": 2 } }, "context": { "diagnostics": [ { "range": { "start": { "line": 3, "character": 1 }, "end": { "line": 3, "character": 4 } }, "severity": 1, "code": "UndeclaredName", "codeDescription": { "href": "https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#UndeclaredName" }, "source": "compiler", "message": "undefined: fmt" } ], "triggerKind": 1 } }Response
[ { "title": "Browse gopls feature documentation", "kind": "gopls.doc.features", "command": { "title": "Browse gopls feature documentation", "command": "gopls.client_open_url", "arguments": [ "https://github.com/golang/tools/blob/master/gopls/doc/features/README.md" ] } }, { "title": "Add import: \"fmt\"", "kind": "quickfix", "diagnostics": [ { "range": { "start": { "line": 3, "character": 1 }, "end": { "line": 3, "character": 4 } }, "severity": 1, "code": "UndeclaredName", "codeDescription": { "href": "https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#UndeclaredName" }, "source": "compiler", "message": "undefined: fmt" } ], "edit": { "documentChanges": [ { "textDocument": { "version": 1, "uri": "file:///Users/user/a/main.go" }, "edits": [ { "range": { "start": { "line": 1, "character": 0 }, "end": { "line": 1, "character": 0 } }, "newText": "\nimport \"fmt\"\n" } ] } ] } }, { "title": "Add test for main", "kind": "source.addTest", "data": { "title": "Add test for main", "command": "gopls.add_test", "arguments": [ { "uri": "file:///Users/user/a/main.go", "range": { "start": { "line": 3, "character": 1 }, "end": { "line": 3, "character": 1 } } } ] } }, { "title": "Browse arm64 assembly for main", "kind": "source.assembly", "command": { "title": "Browse arm64 assembly for main", "command": "gopls.assembly", "arguments": [ "1", "a", "main.main" ] } }, { "title": "Browse documentation for package main", "kind": "source.doc", "command": { "title": "Browse documentation for package main", "command": "gopls.doc", "arguments": [ { "Location": { "uri": "file:///Users/user/a/main.go", "range": { "start": { "line": 3, "character": 1 }, "end": { "line": 3, "character": 1 } } }, "ShowDocument": true } ] } }, { "title": "Organize Imports", "kind": "source.organizeImports", "edit": { "documentChanges": [ { "textDocument": { "version": 1, "uri": "file:///Users/user/a/main.go" }, "edits": [ { "range": { "start": { "line": 1, "character": 0 }, "end": { "line": 1, "character": 0 } }, "newText": "\nimport \"fmt\"\n" } ] } ] } } ]The text was updated successfully, but these errors were encountered: