-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: local version stamping doesn't work with v2+ #72877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@golang/compiler @matloob |
gocryptfs author here. Same thing on Linux @samthanawalla :
|
i'm seeing the old (devel) behavior even on non 2+ using the 1.24 toolchain / mod version (version of code was 1.2.4). I expected to see the new marked +dirty behavior at worst as documented in the release notes instead. (the repo was clean so it should just work.) |
@bdunlap-synack details ? repro how? |
Change https://go.dev/cl/661875 mentions this issue: |
Go version
go version go1.24.1 windows/amd64
Output of
go env
in your module/workspace:What did you do?
ReadBuildInfo.Main.Version shows "(devel)" after tagging v2 package as v2.
Although my personal case may be different - I'm not 100% sure how I broke this feature in my private repo - the scenario below successfully reproduces the same output, so I think it's still worth reporting.
Thanks to user truck.dad from the Discord Gophers server for his initial support and the Unix PoC!
What did you see happen?
What did you expect to see?
or pseudoversion, or literally anything other than "(devel)"
The text was updated successfully, but these errors were encountered: