go.tools/dashboard/builder: build is broken but not detected by build.golang.org

[davecheney]

What steps will reproduce the problem?

The go.tools repo contains an error

% go build code.google.com/p/go.tools/...
# code.google.com/p/go.tools/dashboard/builder
dashboard/builder/env.go:10: imported and not used: "io"

But the dashboard is not showing an error.

What is the expected output? What do you see instead?

This is because the dashboard builds sub repos as

go get -d code.google.com/p/go.$REPO/...
go test code.google.com/p/go.$REPO/...

because the dashboard/builder package has no tests, no attempt to validate the non test
code is made

Please use labels and text to provide additional information.

[davecheney]

Comment 2:

https://golang.org/cl/66800043

Labels changed: added release-go1.3, removed release-none.

Owner changed to @davecheney.

Status changed to Started.

[alexbrainman]

Comment 3:

Is this related to issue #7108? Should we fix general Problem instead?
Alex

[davecheney]

Comment 4:

Yes. I couldn't find that issue but I had a feeling it had been discussed.
This is really a stop gap measure, I'm happy to merge it into issue #7108 if there is an
indication that a more comprehensive solution is desired.

[davecheney]

Comment 5:

This issue was updated by revision golang/tools@1c1af4b.

This slipped into the build in revision 4b4229fc616b.
Thanks to @pierredurand87 for noticing the break.
LGTM=bgarcia
R=golang-codereviews, bgarcia
CC=golang-codereviews
https://golang.org/cl/66670043

[rsc]

Comment 6:

Status changed to Duplicate.

Merged into issue #7108.