Skip to content

fmt: document the behaviour of %p on slices #24600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fmt: document the behaviour of %p on slices #24600

wants to merge 2 commits into from

Conversation

mewmew
Copy link
Contributor

@mewmew mewmew commented Mar 29, 2018

Fixes #23291.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 29, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: 3f3ec2d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/103516 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/103516.
After addressing review feedback, remember to publish your drafts!

@mewmew mewmew mentioned this pull request Mar 29, 2018
Closed
@gopherbot
Copy link
Contributor

Message from Rob Pike:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/103516.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: bc34442) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/103516 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Robin Eklind:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/103516.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 30, 2018
@mewmew @robpike
fmt: document the behaviour of %p on slices
b8620af 
Fixes #23291.

Change-Id: I9bb3b8246968693871d4800e2cdb2c8390f4b6a6
GitHub-Last-Rev: bc34442
GitHub-Pull-Request: #24600
Reviewed-on: https://go-review.googlesource.com/103516
Reviewed-by: Rob Pike <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/103516 has been merged.

@gopherbot gopherbot closed this Mar 30, 2018
imryao pushed a commit to imryao/biscuit that referenced this pull request Mar 15, 2023
@mewmew @imryao
fmt: document the behaviour of %p on slices
061e9e5 
Fixes #23291.

Change-Id: I9bb3b8246968693871d4800e2cdb2c8390f4b6a6
GitHub-Last-Rev: bc3444206764016b730d770a8c71a49c214ae824
GitHub-Pull-Request: golang/go#24600
Reviewed-on: https://go-review.googlesource.com/103516
Reviewed-by: Rob Pike <[email protected]>
(cherry picked from commit b8620afb8d17a2b884f20535ccbc21b192b75b3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mewmew @gopherbot @googlebot