syscall: implement pipe() on linux/mips #26608
Conversation
Change the Pipe() function to use the pipe() syscall (which has a unique calling convention on linux/mips) instead of using pipe2(). This allows it work on kernels <2.6.27 when pipe2() was introduced.
googlebot
added
the
cla: yes
|
Message from Gerrit User 5065: Patch Set 1: Since this change doesn't reference a bug number, I assume this is for Go 1.12. Please don’t reply on this GitHub thread. Visit golang.org/cl/125915. |
|
Message from Gerrit User 28484: Patch Set 1: It would be nice if it could go in before then. I can open an issue with a simple program that doesn't work if that would help (basically fork/exec doesn't work, probably among other things). The only reason this is relevant is because many routers use old kernels on mips hardware and it would be great if they were supported better. Please don’t reply on this GitHub thread. Visit golang.org/cl/125915. |
|
Message from Gerrit User 5206: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/125915. |
|
Message from Gerrit User 5976: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=229645b4 Please don’t reply on this GitHub thread. Visit golang.org/cl/125915. |
|
Message from Gerrit User 5976: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/125915. |
|
Message from Gerrit User 15150: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/125915. |
|
Message from Gerrit User 5206: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/125915. |
Change the Pipe() function to use the pipe() syscall (which has a unique calling convention on linux/mips) instead of using pipe2(). This allows it work on kernels <2.6.27 when pipe2() was introduced. Change-Id: I65dfbd2a02b64e777a8eb13013d718e356521be6 GitHub-Last-Rev: c483a06 GitHub-Pull-Request: #26608 Reviewed-on: https://go-review.googlesource.com/125915 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Vladimir Stefanovic <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
|
This PR is being closed because golang.org/cl/125915 has been merged. |
Change the Pipe() function to use the pipe() syscall (which has a unique
calling convention on linux/mips) instead of using pipe2(). This allows
it work on kernels <2.6.27 when pipe2() was introduced.