Skip to content

database/sql: allow Scan to work with structs #26646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

database/sql: allow Scan to work with structs #26646

wants to merge 2 commits into from

Conversation

moltzaum
Copy link

@moltzaum moltzaum commented Jul 27, 2018

The default behavior of structs is now to sequentially scan the struct fields.
If some of the fields are unexported, the new implementation will defer to the
old behavior. This change does not affect any types that already implement the
Scanner interface.

Testing for embedded struct added.

Updates #22697 (database/sql wishlish)
Fixes jmoiron/sqlx#162

moltzaum and others added 2 commits July 27, 2018 08:45
The default behavior of structs is now to sequentially scan the struct fields.
If some of the fields are unexported, the new implementation will defer to the
old behavior. This change does not affect any types that already implement the
Scanner interface.

Testing for embedded struct added.
database/sql: allow Scan to work with structs
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jul 27, 2018
@moltzaum
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jul 27, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/126416.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/126416.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.


Please don’t reply on this GitHub thread. Visit golang.org/cl/126416.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5080:

Patch Set 3: Code-Review-2

Thank you for this CL. Typically before we add a feature we create an issue "proposal: do such and such", the proposal is accepted, and then code is written.

Sometimes we make initial implementations to go along with the proposal to help see how it would look, even if the initial implementation isn't used.

This adds significant behavior to database/sql. Please open a new issue beginning with "proposal: ...", mention me "@kardianos", and we can talk about the design. In the mean time I'm marking this as won't merge. To be upfront, I would like to do this, but chances are it won't be in this manner.


Please don’t reply on this GitHub thread. Visit golang.org/cl/126416.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/126416 has been abandoned.

@gopherbot gopherbot closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants