-
Notifications
You must be signed in to change notification settings - Fork 18k
database/sql: allow Scan to work with structs #26646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The default behavior of structs is now to sequentially scan the struct fields. If some of the fields are unexported, the new implementation will defer to the old behavior. This change does not affect any types that already implement the Scanner interface. Testing for embedded struct added.
database/sql: allow Scan to work with structs
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/126416. |
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/126416. |
Message from Gerrit User 12446: Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2. Please don’t reply on this GitHub thread. Visit golang.org/cl/126416. |
Message from Gerrit User 5080: Patch Set 3: Code-Review-2 Thank you for this CL. Typically before we add a feature we create an issue "proposal: do such and such", the proposal is accepted, and then code is written. Sometimes we make initial implementations to go along with the proposal to help see how it would look, even if the initial implementation isn't used. This adds significant behavior to database/sql. Please open a new issue beginning with "proposal: ...", mention me "@kardianos", and we can talk about the design. In the mean time I'm marking this as won't merge. To be upfront, I would like to do this, but chances are it won't be in this manner. Please don’t reply on this GitHub thread. Visit golang.org/cl/126416. |
0090c13
to
8fbbf63
Compare
This PR is being closed because golang.org/cl/126416 has been abandoned. |
The default behavior of structs is now to sequentially scan the struct fields.
If some of the fields are unexported, the new implementation will defer to the
old behavior. This change does not affect any types that already implement the
Scanner interface.
Testing for embedded struct added.
Updates #22697 (database/sql wishlish)
Fixes jmoiron/sqlx#162