net: add text marshalling and unmarshalling for HardwareAddr #34452

klnusbaum · 2019-09-21T22:19:04Z

The HardwareAddr type has the ability to be transformed to and from a
string. However, this capability is not exposed in a manner suitable
for use with various forms of marshalling and unmarshaling of text
(e.g. JSON or YAML). Let's add the proper functions so that
HardwareAddr implements the TextMarshaller and TextUnmarshaler
interfaces from the encoding package.

Fixes #29678

gopherbot · 2019-09-21T22:34:56Z

This PR (HEAD: 85a3e00) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/196817 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-21T22:36:41Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-22T01:32:37Z

Message from Akhil Indurti:

Patch Set 1: Code-Review-1

Hey Kurtis, thank you for submitting this! I think we should wait for the issue to resolve first w.r.t the backwards compatibility concerns.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-24T03:08:05Z

This PR (HEAD: b18832e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/196817 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-24T14:20:43Z

Message from Kurtis Nusbaum:

Patch Set 2:

Patch Set 1: Code-Review-1

Hey Kurtis, thank you for submitting this! I think we should wait for the issue to resolve first w.r.t the backwards compatibility concerns.

Hey Ankhil,
Looks like we've got a solution for the backwards compatibility concerns. Would it be ok if we move forward with a more in-depth review of the change now?

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

googlebot · 2019-09-26T21:53:18Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

The HardwareAddr type has the ability to be transformed to and from a string. However, this capability is not exposed in a manner suitable for use with various forms of marshalling and unmarshaling of text (e.g. JSON or YAML). Let's add the proper functions so that HardwareAddr implements the TextMarshaller and TextUnmarshaler interfaces from the encoding package. Fixes golang#29678

…ompatibility reasons

- Create `matchErr` function and simplify result testing in `TestHardwareAddr_UnmarshalText` - Fix Lbrace in `TestHardwareAddr_UnmarshalText` - Change `Fatalf`s to just `Fatal`s in `TestHardwareAddr_MarshalText`

googlebot · 2019-09-30T13:54:29Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gopherbot · 2019-09-30T14:01:07Z

Message from Akhil Indurti:

Patch Set 2:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-30T14:01:17Z

This PR (HEAD: df49700) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/196817 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-30T14:02:39Z

This PR (HEAD: 9e07592) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/196817 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-02T17:47:17Z

Message from Akhil Indurti:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-02T18:49:12Z

This PR (HEAD: 5660642) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/196817 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-02T18:59:49Z

Message from Akhil Indurti:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T07:05:08Z

Message from Akhil Indurti:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T07:06:12Z

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2afdb754

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T07:14:32Z

Message from Gobot Gobot:

Patch Set 5:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/2afdb754/freebsd-amd64-12_0_0528e059.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T07:16:38Z

Message from Gobot Gobot:

Patch Set 5: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T07:19:51Z

Message from Akhil Indurti:

Patch Set 5: -Run-TryBot -Code-Review

Seems like the base64 import violates the policy defined in go/build/deps_test.go. Is it absolutely needed for Unmarshal? If so, this needs to be discussed in the issue.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-18T02:31:31Z

Message from Kurtis Nusbaum:

Patch Set 5:

Patch Set 5: -Run-TryBot -Code-Review

Seems like the base64 import violates the policy defined in go/build/deps_test.go. Is it absolutely needed for Unmarshal? If so, this needs to be discussed in the issue.

Hey Akhil,

This actually was discussed on the issue. The claim was that in order to be truly backwards compatible with pervious versions of Go, we needed to be able to decode the potentially base64 encoded byte arrays that theoretically may be have serialized in current and previous versions of Go. I don't know of any other way to do that besides using the base64 package (or copy and pasting from the base64 package). It seems we're stuck between two requirements here. Which would you prefer I go with? Or is there a third option?

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:43:39Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:43:40Z

Message from Go Bot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2afdb754

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:43:41Z

Message from Go Bot:

Patch Set 5:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/2afdb754/freebsd-amd64-12_0_0528e059.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:43:42Z

Message from Go Bot:

Patch Set 5: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/196817.
After addressing review feedback, remember to publish your drafts!

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 21, 2019

klnusbaum force-pushed the haddr branch from b18832e to 4ce032c Compare September 26, 2019 21:53

googlebot added cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. and removed cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. labels Sep 26, 2019

klnusbaum added 3 commits September 30, 2019 06:36

add ability to decode strings repsenting a byte slice for backwards c…

084018d

…ompatibility reasons

- Add some more docstring to UnmarshalText

df49700

- Create `matchErr` function and simplify result testing in `TestHardwareAddr_UnmarshalText` - Fix Lbrace in `TestHardwareAddr_UnmarshalText` - Change `Fatalf`s to just `Fatal`s in `TestHardwareAddr_MarshalText`

klnusbaum force-pushed the haddr branch from 4ce032c to df49700 Compare September 30, 2019 13:54

googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Sep 30, 2019

Standardize casing of MAC in doc strings

9e07592

gopherbot force-pushed the master branch from a1b0af9 to 93a79bb Compare October 1, 2019 22:09

move matchErr to be a closure within the test

5660642

gopherbot force-pushed the master branch 2 times, most recently from 07b4abd to 19a7490 Compare October 9, 2019 22:40

gopherbot force-pushed the master branch from 03fb1f6 to a813d3c Compare October 22, 2019 19:40

gopherbot force-pushed the master branch 10 times, most recently from 4a7ed1f to 0f992b9 Compare November 5, 2019 02:56

gopherbot force-pushed the master branch from a408139 to 5764653 Compare September 14, 2020 21:26

heschi closed this Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: add text marshalling and unmarshalling for HardwareAddr #34452

net: add text marshalling and unmarshalling for HardwareAddr #34452

klnusbaum commented Sep 21, 2019

gopherbot commented Sep 21, 2019

gopherbot commented Sep 21, 2019

gopherbot commented Sep 22, 2019

gopherbot commented Sep 24, 2019

gopherbot commented Sep 24, 2019

googlebot commented Sep 26, 2019

googlebot commented Sep 30, 2019

gopherbot commented Sep 30, 2019

gopherbot commented Sep 30, 2019

gopherbot commented Sep 30, 2019

gopherbot commented Oct 2, 2019

gopherbot commented Oct 2, 2019

gopherbot commented Oct 2, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 18, 2019

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

net: add text marshalling and unmarshalling for HardwareAddr #34452

net: add text marshalling and unmarshalling for HardwareAddr #34452

Conversation

klnusbaum commented Sep 21, 2019

gopherbot commented Sep 21, 2019

gopherbot commented Sep 21, 2019

gopherbot commented Sep 22, 2019

gopherbot commented Sep 24, 2019

gopherbot commented Sep 24, 2019

googlebot commented Sep 26, 2019

googlebot commented Sep 30, 2019

gopherbot commented Sep 30, 2019

gopherbot commented Sep 30, 2019

gopherbot commented Sep 30, 2019

gopherbot commented Oct 2, 2019

gopherbot commented Oct 2, 2019

gopherbot commented Oct 2, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 18, 2019

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020