database/sql: preallocate list slice in Drivers() #34602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

julienschmidt wants to merge 1 commit into golang:master from julienschmidt:sql-drivers-prealloc

Contributor

julienschmidt commented Sep 30, 2019 •

edited

Loading

The required slice capacity is already known. Thus, preallocate a slice with the correct capacity before appending to it.


          database/sql: preallocate list slice in Drivers()

2bf575b

googlebot added the cla: yes label

Contributor

gopherbot commented Sep 30, 2019

This PR (HEAD: 2bf575b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/197917 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Sep 30, 2019

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2019

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/197917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2019

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/197917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2019

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=de2e15f4

Please don’t reply on this GitHub thread. Visit golang.org/cl/197917.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 30, 2019

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197917.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          database/sql: preallocate list slice in Drivers()

843fec1

The required slice capacity is already known. Thus, preallocate a slice with the correct capacity before appending to it.

Change-Id: I45ac2c5f1701caeb3dda20451d371713ae7e7365
GitHub-Last-Rev: 2bf575b
GitHub-Pull-Request: #34602
Reviewed-on: https://go-review.googlesource.com/c/go/+/197917
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>

Contributor

gopherbot commented Sep 30, 2019

This PR is being closed because golang.org/cl/197917 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels