encoding/binary: removal of unnecessary boundary checks.

[ghost]

When creating a slice, e.g.: a 4 byte array can become optimized to 3 bytes only, resulting in a panic from the boundary check, which was experienced during decoding of LoRa packets.

Fixes issue #14808.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[ghost]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[gopherbot]

This PR (HEAD: 801ef65) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202517 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/202517.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

The description says that you are removing unnecessary boundary checks, but that's not what you are doing. You are changing the behavior of these methods when a short slice is passed in.

I don't see why that is desirable. The methods expect full size slices and should not be called on short slices. It's very easy for calling code to avoid calling these methods if they will not work.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/202517.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review-2

Also, these patterns are recognized by the compiler and optimized to single instructions.

This CL is almost certainly much slower than the original, in addition to changing the behavior.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/202517.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Lemmer El Assal:

Patch Set 1:

Patch Set 1:

The description says that you are removing unnecessary boundary checks, but that's not what you are doing. You are changing the behavior of these methods when a short slice is passed in.

Go optimizes a []byte subslice of 4 (e.g.: buffer[4:9]) to shorter slices when the value is 0, which cause a panic.

Would it be preferrable to add this as a separate function altogether?

I don't see why that is desirable. The methods expect full size slices and should not be called on short slices. It's very easy for calling code to avoid calling these methods if they will not work.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/202517.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 1:

Patch Set 1:

Patch Set 1:

The description says that you are removing unnecessary boundary checks, but that's not what you are doing. You are changing the behavior of these methods when a short slice is passed in.

Go optimizes a []byte subslice of 4 (e.g.: buffer[4:9]) to shorter slices when the value is 0, which cause a panic.

I don't understand. Which value?

Would it be preferrable to add this as a separate function altogether?

I don't know which function you want so I can't say.

I don't see why that is desirable. The methods expect full size slices and should not be called on short slices. It's very easy for calling code to avoid calling these methods if they will not work.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/202517.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/202517.
After addressing review feedback, remember to publish your drafts!