Skip to content

runtime: fix typo in loadFactor comment #38191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

maronghe
Copy link
Contributor

@maronghe maronghe commented Apr 1, 2020

Fixes #38174

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 1, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: f0c9681) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/226758 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/226758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alberto Donizetti:

Patch Set 1:

Small nit: the commit title shouldn't say what the issue is, but what
the commit does to fix it. I would change the title to:

runtime: fix typo in loadFactor comment

and remove this line from the description:

This CL fix typo in map.go file line 69.

leaving just the final "Fixes ..." part.


Please don’t reply on this GitHub thread. Visit golang.org/cl/226758.
After addressing review feedback, remember to publish your drafts!

@maronghe maronghe changed the title runtime: comment in map.go misspells loadFactorDen variable name runtime: fix typo in loadFactor comment Apr 1, 2020
@gopherbot
Copy link
Contributor

Message from logan ma:

Patch Set 1:

Patch Set 1:

Small nit: the commit title shouldn't say what the issue is, but what
the commit does to fix it. I would change the title to:

runtime: fix typo in loadFactor comment

and remove this line from the description:

This CL fix typo in map.go file line 69.

leaving just the final "Fixes ..." part.

Oh.Thank you for your good point. I got it now.
And I have fixed the pull request right now.


Please don’t reply on this GitHub thread. Visit golang.org/cl/226758.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 1, 2020
Fixes #38174

Change-Id: Iacdbbcd0b4586302daf082e59d833b7aa58b1a6a
GitHub-Last-Rev: f0c9681
GitHub-Pull-Request: #38191
Reviewed-on: https://go-review.googlesource.com/c/go/+/226758
Reviewed-by: Alberto Donizetti <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/226758 has been merged.

@gopherbot gopherbot closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime: comment in map.go misspells loadFactorDen variable name
3 participants