Skip to content

cmd/go/internal/get: add GOINSECURE support #38628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

cmd/go/internal/get: add GOINSECURE support #38628

wants to merge 3 commits into from

Conversation

witchard
Copy link
Contributor

Adds support for the GOINSECURE environment variable to GOPATH mode.

Updates #37519.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 23, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 80cdd63) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/229758 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1 Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=105c444b

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 26b2f7e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/229758 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2: Run-TryBot+1 Code-Review+2

Approving for merge, but let's give it until Monday to give other folks a chance to chime in.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=75efeeab

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 2:

Patch Set 2: Run-TryBot+1 Code-Review+2

Approving for merge, but let's give it until Monday to give other folks a chance to chime in.

Sounds good, thank you. Do you think this means the deprecation proposal can be taken off of hold, or is there anything else you’d like me to look at?

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 2:

Hey, just checking this hasn’t got forgotten 😊

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 2:

Patch Set 2:

Hey, just checking this hasn’t got forgotten 😊

Ah sorry, I realise that the feature freeze for 1.15 has started already... no worries!

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 3: Patch Set 2 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=e6eb22c3

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

Build is still in progress...
This change failed on openbsd-amd64-64:
See https://storage.googleapis.com/go-build-log/e6eb22c3/openbsd-amd64-64_70f73ecd.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3: TryBot-Result-1

1 of 22 SlowBots failed:
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/e6eb22c3/openbsd-amd64-64_70f73ecd.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.SlowBot builds that ran:

  • linux-amd64-longtest
  • windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3: TryBot-Result+1

SlowBots are happy.
SlowBot builds that ran:

  • linux-amd64-longtest
  • windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 4: Patch Set 3 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=7c2e265a

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on linux-amd64-longtest:
See https://storage.googleapis.com/go-build-log/7c2e265a/linux-amd64-longtest_ee21c176.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result-1

22 of 22 SlowBots failed:
Failed on linux-amd64-longtest: https://storage.googleapis.com/go-build-log/7c2e265a/linux-amd64-longtest_ee21c176.log
Failed on misc-compile-netbsd: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-netbsd_55f3287f.log
Failed on misc-compile-ppc: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-ppc_8b4dde85.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/7c2e265a/freebsd-amd64-12_0_658069cf.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/7c2e265a/linux-amd64_0ce5f983.log
Failed on windows-amd64-longtest: https://storage.googleapis.com/go-build-log/7c2e265a/windows-amd64-longtest_e5bee81b.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/7c2e265a/js-wasm_ffd5918f.log
Failed on misc-compile-other: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-other_56bb14b7.log
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/7c2e265a/linux-amd64_211271e8.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/7c2e265a/openbsd-amd64-64_8d757bf8.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/7c2e265a/windows-amd64-2016_c3ba9839.log
Failed on misc-compile-mips: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-mips_8adce069.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/7c2e265a/android-amd64-emu_788508bd.log
Failed on misc-compile-openbsd: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-openbsd_30f2c505.log
Failed on misc-compile-darwin: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-darwin_45567ac6.log
Failed on misc-compile-plan9: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-plan9_33f6a64e.log
Failed on misc-compile-freebsd: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-freebsd_75c73b06.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/7c2e265a/linux-386_aee1c0ef.log
Failed on misc-compile-linuxarm: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-linuxarm_e44ffa75.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/7c2e265a/windows-386-2008_688ae4bf.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/7c2e265a/linux-amd64-race_6fda5388.log
Failed on misc-compile-solaris: https://storage.googleapis.com/go-build-log/7c2e265a/misc-compile-solaris_12286238.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.SlowBot builds that ran:

  • linux-amd64-longtest
  • windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 5: Patch Set 4 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=860675b6

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/860675b6/freebsd-amd64-12_0_6bec52e1.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5: TryBot-Result-1

22 of 22 SlowBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/860675b6/freebsd-amd64-12_0_6bec52e1.log
Failed on misc-compile-netbsd: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-netbsd_170d9352.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/860675b6/linux-amd64_b1e4667d.log
Failed on misc-compile-linuxarm: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-linuxarm_bbd37b98.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/860675b6/windows-amd64-2016_a3dea2dc.log
Failed on misc-compile-plan9: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-plan9_a7bfaf9c.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/860675b6/android-amd64-emu_9138a6fb.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/860675b6/windows-386-2008_429dbf03.log
Failed on misc-compile-openbsd: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-openbsd_f3523a98.log
Failed on misc-compile-mips: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-mips_d5304321.log
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/860675b6/linux-amd64_d3c1096a.log
Failed on misc-compile-solaris: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-solaris_228ae13f.log
Failed on misc-compile-ppc: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-ppc_dec62b2e.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/860675b6/linux-amd64-race_a4f6547e.log
Failed on misc-compile-freebsd: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-freebsd_e668db8a.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/860675b6/openbsd-amd64-64_06501428.log
Failed on misc-compile-other: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-other_34105b83.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/860675b6/linux-386_92aa7edf.log
Failed on misc-compile-darwin: https://storage.googleapis.com/go-build-log/860675b6/misc-compile-darwin_67ae6c37.log
Failed on linux-amd64-longtest: https://storage.googleapis.com/go-build-log/860675b6/linux-amd64-longtest_0ca70359.log
Failed on windows-amd64-longtest: https://storage.googleapis.com/go-build-log/860675b6/windows-amd64-longtest_db06749c.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/860675b6/js-wasm_03c4b687.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.SlowBot builds that ran:

  • linux-amd64-longtest
  • windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@witchard witchard force-pushed the get-GOPATH-GOINSECURE branch from 26b2f7e to e298c00 Compare August 30, 2020 18:14
@gopherbot
Copy link
Contributor

This PR (HEAD: e298c00) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/229758 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 6:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=ae599802

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

SlowBots are happy.
SlowBot builds that ran:

  • linux-amd64-longtest
  • windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/229758.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 1, 2020
@witchard
cmd/go/internal/get: add GOINSECURE support
ac55d58 
Adds support for the GOINSECURE environment variable to GOPATH mode.

Updates #37519.

Change-Id: Ibe3f52b7f30b1395edb000998905ee93abe6cada
GitHub-Last-Rev: e298c00
GitHub-Pull-Request: #38628
Reviewed-on: https://go-review.googlesource.com/c/go/+/229758
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/229758 has been merged.

@gopherbot gopherbot closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@witchard @gopherbot @googlebot