Skip to content

crypto/x509: change docs to clarify the meaning of PEM encryption #42039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

HarikrishnanBalagopal
Copy link

@HarikrishnanBalagopal HarikrishnanBalagopal commented Oct 17, 2020

The existing documentation does not mention the exact meaning of
"PEM encryption". So add a note to clarify that it is referring to
RFC 1423 and that the functions are not meant to support any newer
standard like PKCS 8.

Updates #41949

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 17, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 9860e80) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263181 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/263181.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: a9e03eb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263181 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

The existing documentation does not mention the exact meaning of
"PEM encryption". So add a note to clarify that it is referring to
RFC 1423 and that the functions are not meant to support any newer
standard like PKCS golang#8.

Updates golang#41949
@gopherbot
Copy link
Contributor

This PR (HEAD: 434faa4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/263181 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@HarikrishnanBalagopal HarikrishnanBalagopal changed the title crypto/x509: change documentation to reflect that PEM encryption refers to a legacy standard that is to be deprecated soon crypto/x509: change docs to clarify the meaning of PEM encryption Oct 17, 2020
@HarikrishnanBalagopal
Copy link
Author

Closing since the issue #41949 has been fixed by 57af974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants