strings: add AppendJoin function for strings.Builder #42850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
With the existing API, we have to call Join and then Builder.WriteString to append a joined string to an existing Builder. If AppendJoin is supported like in C#'s StringBuilder.AppendJoin, we can avoid some extra allocation (Join creates a strings.Builder under the hood).
suzaku
force-pushed
the
builder-append-join
branch
from
8b9eab5 to
3756cc7
Compare
|
This PR (HEAD: 3756cc7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/273646 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: Code-Review-2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/273646. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the existing API, we have to call Join and then
Builder.WriteString to append a joined string to an existing Builder.
If AppendJoin is supported like in C#'s StringBuilder.AppendJoin, we can
avoid some extra allocation (Join creates a strings.Builder under the
hood).