go/doc: avoid panic on references to functions with no body #43011
Conversation
google-cla
bot
added
the
cla: yes
|
I'm not sure the test case is in the most logical place. The whole file test section allowed easy recreation of the issue's example. |
|
This PR (HEAD: ad078e6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/275516 to see it. Tip: You can toggle comments from me using the |
qbradq
changed the title
|
Message from Daniel Martí: Patch Set 2: Run-TryBot+1 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=3a09e7e5 Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Norman Lancaster: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Daniel Martí: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Norman Lancaster: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Daniel Martí: Patch Set 3: Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Emmanuel Odeke: Patch Set 3: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
@qbradq please rebase your PR with the latest from the master branch so that we can run tests, and then merge it. Thank you! |
This change guards a call to ast.Inspect with a nil check on the first argument. This avoids a panic when inspecting a reference to a function with an external body. Fixes golang#42706
|
This PR (HEAD: 08072b9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/275516 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 4: Patch Set 3 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Daniel Martí: Patch Set 5: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
|
Message from Go Bot: Patch Set 5: TryBots beginning. Status page: https://farmer.golang.org/try?commit=49553924 Please don’t reply on this GitHub thread. Visit golang.org/cl/275516. |
This change guards a call to ast.Inspect with a nil check on the first argument. This avoids a panic when inspecting a reference to a function with a nil body. This can only happen when a function body is defined outside Go. Fixes #42706 Change-Id: I91bc607b24b6224920c24cfd07e76ce7737a98d4 GitHub-Last-Rev: 08072b9 GitHub-Pull-Request: #43011 Reviewed-on: https://go-review.googlesource.com/c/go/+/275516 Reviewed-by: Daniel Martí <[email protected]> Trust: Daniel Martí <[email protected]> Trust: Emmanuel Odeke <[email protected]> Run-TryBot: Daniel Martí <[email protected]> TryBot-Result: Go Bot <[email protected]>
|
This PR is being closed because golang.org/cl/275516 has been merged. |
This change guards a call to ast.Inspect with a nil check on the first
argument. This avoids a panic when inspecting a reference to a function
with a nil body. This can only happen when a function body is defined outside Go.
Fixes #42706