Skip to content

log: improve logger implementation #48464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

log: improve logger implementation #48464

wants to merge 5 commits into from

Conversation

burakkoken
Copy link

The current implementation of the log.Logger provides us with
limited flexibility. With the new changes, it will provide more
flexibility. The changes introduce new features such as Log Level,
Formatter, Root Logger, Context support etc. but the changes made
won't break any existing functionalities or affect any libraries
which use log package. Thanks to the changes made, any custom logger
implementation won't be needed and developer needs will be met.
Instead, the formatter can be used to format the output.

Fixes #13182

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 18, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 20c4f5b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/350869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/350869.
After addressing review feedback, remember to publish your drafts!

@burakkoken
log: improve Logger implementation
082cde2 
The current implementation of the log.Logger provides us with limited flexibility.
With the new changes, it will provide more flexibility. The changes introduce new
features such as Log Level, Formatter, Root Logger, Context support etc. but
the changes made won't break any existing functionalities or affect any libraries
which use log package. Thanks to the changes made, any custom logger implementation
won't be needed and developer needs will be met. Instead, the formatter can be used
to format the output.

Fixes golang#13182
@burakkoken
log: improve Logger implementation
20c4f5b 
The current implementation of the log.Logger provides us with limited flexibility.
With the new changes, it will provide more flexibility. The changes introduce new
features such as Log Level, Formatter, Root Logger, Context support etc. but
the changes made won't break any existing functionalities or affect any libraries
which use log package. Thanks to the changes made, any custom logger implementation
won't be needed and developer needs will be met. Instead, the formatter can be used
to format the output.

Fixes golang#13182
@burakkoken burakkoken mentioned this pull request Sep 18, 2021
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: c357000) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/350869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@burakkoken
log: improve Logger implementation
c357000 
The current implementation of the log.Logger provides us with limited flexibility.
With the new changes, it will provide more flexibility. The changes introduce new
features such as Log Level, Formatter, Root Logger, Context support etc. but
the changes made won't break any existing functionalities or affect any libraries
which use log package. Thanks to the changes made, any custom logger implementation
won't be needed and developer needs will be met. Instead, the formatter can be used
to format the output.

Fixes golang#13182
@gopherbot
Copy link
Contributor

This PR (HEAD: ffc9536) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/350869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@burakkoken
log: improve Logger implementation
ffc9536 
The current implementation of the log.Logger provides us with limited flexibility.
With the new changes, it will provide more flexibility. The changes introduce new
features such as Log Level, Formatter, Root Logger, Context support etc. but
the changes made won't break any existing functionalities or affect any libraries
which use log package. Thanks to the changes made, any custom logger implementation
won't be needed and developer needs will be met. Instead, the formatter can be used
to format the output.

Fixes golang#13182
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350869.
After addressing review feedback, remember to publish your drafts!

@burakkoken burakkoken mentioned this pull request Sep 20, 2021
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: 2fe9a32) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/350869 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@burakkoken
log: improve Logger implementation
2fe9a32 
The current implementation of the log.Logger provides us with limited flexibility.
With the new changes, it will provide more flexibility. The changes introduce new
features such as Log Level, Formatter, Root Logger, Context support etc. but
the changes made won't break any existing functionalities or affect any libraries
which use log package. Thanks to the changes made, any custom logger implementation
won't be needed and developer needs will be met. Instead, the formatter can be used
to format the output.

Fixes golang#13182
@burakkoken burakkoken closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: log: change Logger to be an interface
2 participants
@burakkoken @gopherbot