Skip to content

doc/go1.18: document http.Transport.Dial* being used in js/wasm #49258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

neilalexander
Copy link
Contributor

@neilalexander neilalexander commented Nov 1, 2021

This PR adds a note into the Go 1.18 changelog for CL 330852.

Updates #46923.

This PR adds a note into the Go 1.18 changelog for CL330852 / golang#46923.
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 1, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: e46591c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/360297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@neilalexander neilalexander changed the title doc: document CL330852 in changelog doc/go1.18: document CL330852 in changelog Nov 2, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 9930605) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/360297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@neilalexander
Copy link
Contributor Author

Related: #47694

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/360297.
After addressing review feedback, remember to publish your drafts!

@neilalexander neilalexander changed the title doc/go1.18: document CL330852 in changelog doc/go1.18: document http.Transport.Dial* being used in js/wasm Nov 9, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 9d4e965) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/360297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Neil Alexander:

Patch Set 4:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/360297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 4: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/360297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/360297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b2772ce) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/360297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Neil Alexander:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/360297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Roland Shoemaker:

Patch Set 5: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/360297.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 11, 2021
This PR adds a note into the Go 1.18 changelog for CL 330852.

Updates #46923.

Change-Id: I99150e9275ce23fcf3697d6a22ac216818223c74
GitHub-Last-Rev: b2772ce
GitHub-Pull-Request: #49258
Reviewed-on: https://go-review.googlesource.com/c/go/+/360297
Trust: Roland Shoemaker <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/360297 has been merged.

@gopherbot gopherbot closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants