-
Notifications
You must be signed in to change notification settings - Fork 18k
net/netip: add a fuzz test #50108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/netip: add a fuzz test #50108
Conversation
This is a pretty straight port of the fuzz test at https://github.com/inetaf/netaddr. Fixes golang#49367
e3b4e2a
to
4ab3c53
Compare
This PR (HEAD: 4ab3c53) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This PR (HEAD: c72b7bc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
c72b7bc
to
1c2fe42
Compare
This PR (HEAD: 1c2fe42) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: ddb7be2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
ddb7be2
to
1c2fe42
Compare
Message from Andrew LeFevre: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Matt Layher: Patch Set 7: Run-TryBot+1 Code-Review+1 Trust+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 7: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Matt Layher: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This PR (HEAD: a4c9d7d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
Message from Andrew LeFevre: Patch Set 8: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Andrew LeFevre: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Matt Layher: Patch Set 8: Run-TryBot+1 Code-Review+1 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Andrew LeFevre: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Matt Layher: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 8: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This is a pretty straight port of the fuzz test at https://github.com/inetaf/netaddr. Fixes golang#49367
a4c9d7d
to
c096ac2
Compare
This PR (HEAD: c096ac2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
Message from Andrew LeFevre: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Matt Layher: Patch Set 9: Run-TryBot+1 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 9: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Matt Layher: Patch Set 9: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Katie Hockman: Patch Set 9: Run-TryBot+1 Code-Review+1 Trust+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This PR (HEAD: aed6930) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
Message from Andrew LeFevre: Patch Set 9: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Katie Hockman: Patch Set 10: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Go Bot: Patch Set 10: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This PR (HEAD: 87f8efe) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
Message from Andrew LeFevre: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Katie Hockman: Patch Set 11: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Gopher Robot: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from Gopher Robot: Patch Set 11: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
Message from thepudds: Patch Set 11: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This PR (HEAD: c2323b0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/371055 to see it. Tip: You can toggle comments from me using the |
Message from Andrew LeFevre: Patch Set 12: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This is a pretty straight port of the fuzz test at https://github.com/inetaf/netaddr. The MarshalText methods of netip.Addr and net.IP, the Is* methods of netip.Addr and net.IP and the MarshalText and String methods of netip.Addr are also checked to ensure that they behave the same way. Fixes #49367 Change-Id: I44abb01f2a7af45f39597992a1fc7ff0305728fa GitHub-Last-Rev: c2323b0 GitHub-Pull-Request: #50108 Reviewed-on: https://go-review.googlesource.com/c/go/+/371055 Trust: Matt Layher <[email protected]> Trust: Katie Hockman <[email protected]> Reviewed-by: Katie Hockman <[email protected]>
Message from Emmanuel Odeke: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371055. |
This PR is being closed because golang.org/cl/371055 has been merged. |
This is a pretty straight port of the fuzz test at https://github.com/inetaf/netaddr.
The MarshalText methods of netip.Addr and net.IP, the Is* methods of netip.Addr
and net.IP and the MarshalText and String methods of netip.Addr are also
checked to ensure that they behave the same way.
Fixes #49367