Skip to content

debug/elf: validate shstrndx #55001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

debug/elf: validate shstrndx #55001

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59eefe5
debug/elf: validate shstrndx
ZekeLu Sep 11, 2022
b7b8c37
remove test for invalid input
ZekeLu Sep 14, 2022
aeb70ca
fix review issues
ZekeLu Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/debug/elf/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,16 @@ func NewFile(r io.ReaderAt) (*File, error) {
}

// Load section header string table.
shstrtab, err := f.Sections[shstrndx].Data()
if shstrndx == 0 {
// If the file has no section name string table,
// shstrndx holds the value SHN_UNDEF (0).
return f, nil
}
shstr := f.Sections[shstrndx]
if shstr.Type != SHT_STRTAB {
return nil, &FormatError{shoff + int64(shstrndx*shentsize), "invalid ELF section name string table type", shstr.Type}
}
shstrtab, err := shstr.Data()
if err != nil {
return nil, err
}
Expand Down