Skip to content

os: add test for UserCacheDir #57809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

os: add test for UserCacheDir #57809

wants to merge 4 commits into from

Conversation

ja7ad
Copy link

@ja7ad ja7ad commented Jan 16, 2023 •
edited
Loading

Fixes #57638

@ja7ad ja7ad mentioned this pull request Jan 16, 2023
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: d93f487) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/462041 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462041.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 8cb19f0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/462041 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462041.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462041.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462041.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/462041.
After addressing review feedback, remember to publish your drafts!

@ja7ad
os: update test use cache dir
0f183ac 
error UserCacheDir skipped and empty string cache dir got fatal.

for test write permission in cache dir add mkdir temp.

Fixes golang#57638 golang#57630
@gopherbot
Copy link
Contributor

This PR (HEAD: 0f183ac) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/462041 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@bcmills
Copy link
Contributor

bcmills commented Feb 6, 2023

I notice that a new PatchSet was uploaded — if this is ready for another review pass, please mark the Gerrit comment threads as resolved and use the Gerrit Reply button to publish your replies.

@seankhliao seankhliao closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os: UserCacheDir and UserConfigDir have no tests
4 participants
@ja7ad @gopherbot @bcmills @seankhliao