net/http/httptest: add support for http.ResponseController to ResponseRecorder #60231
Conversation
…rder CL golang#54136 (implemented in Go 1.20) added the "http".ResponseController type, which allows manipulating per-request timeouts. This is especially useful for programs managing long-running HTTP connections such as Mercure. However, testing HTTP handlers leveraging per-request timeouts is currently cumbersome (even if doable) because "net/http/httptest".ResponseRecorder isn't compatible yet with "http".ResponseController. This patch makes ResponseRecorder compatible with "http".ResponseController. All new methods are part of the contract that response types must honor to be usable with "http".ResponseController. NewRecorderWithDeadlineAwareRequest() is necessary to test read deadlines, as calling rw.SetReadDeadline() must change the deadline on the request body. Fixes golang#60229.
dunglas
force-pushed
the
httptest_recorder_responsecontroller
branch
from
42f634a to
8e5d8d7
Compare
|
This PR (HEAD: 8e5d8d7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/495295 to see it. Tip: You can toggle comments from me using the |
Co-authored-by: Pascal Borreli <[email protected]>
|
This PR (HEAD: 577f6cf) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/495295 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 82674e6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/495295 to see it. Tip: You can toggle comments from me using the |
Proposal #54136 (implemented in CL 436890 which is part of Go 1.20) added the "http".ResponseController type, which allows manipulating per-request timeouts. This is especially useful for programs managing long-running HTTP connections such as Mercure.
However, testing HTTP handlers leveraging per-request timeouts is currently cumbersome (even if doable) because
"net/http/httptest".ResponseRecorder isn't compatible yet with "http".ResponseController.
This patch makes ResponseRecorder compatible with
"http".ResponseController.
All new methods are part of the contract that response types must honor to be usable with "http".ResponseController.
Deadlines are recorded but not enforced to prevent flaky tests.
Fixes #60229.