cmd/go: make malformed go.sum a fatal error #62588

chmeliik · 2023-09-12T10:28:51Z

In CL 197062, many errors related to go.sum were changed from base.Fatal
to error returns. The malformed go.sum error was lost in the process.
Currently, when go encounters a malformed go.sum file, go will read the
well-formed part of the file and then silently ignore the rest.

The motivation behind moving away from base.Fatal was to make the errors
show up in -json output. Simply propagating the malformed go.sum error
would not achieve this:

For an argument-less 'go mod download -json' with a go>=1.17 module,
a malformed go.sum causes an error during LoadModGraph already, before
go ever starts downloading modules and printing their JSON.
In other cases, a malformed go.sum would be reported as Error for one
of the modules (presumably the one which gets downloaded first) but
none of the others.
In either case, 'go mod download' manages to download enough data to
succeed on a re-run, making the error look intermittent.

Switch the error back to a Fatal one, but give 'go mod tidy' an
exception to let it fix broken go.sum files.

Fixes #62345

gopherbot · 2023-09-12T10:38:37Z

This PR (HEAD: 8608968) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527575.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-12T10:45:03Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T14:00:16Z

Message from Bryan Mills:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T16:42:44Z

This PR (HEAD: b176d66) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527575.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-14T16:55:35Z

Message from Adam Cmiel:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T17:02:29Z

This PR (HEAD: 40569c4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527575.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-14T17:09:04Z

Message from Adam Cmiel:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T17:09:05Z

Message from Adam Cmiel:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-15T21:39:19Z

Message from Bryan Mills:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T07:47:27Z

This PR (HEAD: b5d5478) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527575.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-18T08:00:54Z

This PR (HEAD: ae4603c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527575.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-18T08:07:30Z

Message from Adam Cmiel:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T14:26:03Z

Message from Bryan Mills:

Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T14:26:04Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-18T14:11:51Z","revision":"0ef41ff446d6f09cbf00105f911cda2a485a5ad4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T14:32:55Z

Message from Bryan Mills:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T14:32:56Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-arm64 has failed

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T14:32:56Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T14:40:12Z

This PR (HEAD: 219ee55) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527575.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-18T14:47:05Z

Message from Adam Cmiel:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T15:00:46Z

Message from Bryan Mills:

Patch Set 6: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T15:00:47Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-18T14:48:44Z","revision":"7537ec08d37e17c7c84c0d09837407e56cd9d0c7"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T15:00:48Z

Message from Bryan Mills:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T15:00:49Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T15:00:50Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-18T19:22:32Z

Message from Bryan Mills:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

In CL 197062, many errors related to go.sum were changed from base.Fatal to error returns. The malformed go.sum error was lost in the process. Currently, when go encounters a malformed go.sum file, go will read the well-formed part of the file and then silently ignore the rest. The motivation behind moving away from base.Fatal was to make the errors show up in -json output. Simply propagating the malformed go.sum error would not achieve this: - For an argument-less 'go mod download -json' with a go>=1.17 module, a malformed go.sum causes an error during LoadModGraph already, before go ever starts downloading modules and printing their JSON. - In other cases, a malformed go.sum would be reported as Error for one of the modules (presumably the one which gets downloaded first) but none of the others. - In either case, 'go mod download' manages to download enough data to succeed on a re-run, making the error look intermittent. Switch the error back to a Fatal one, but give 'go mod tidy' an exception to let it fix broken go.sum files. Fixes golang#62345

gopherbot · 2023-09-19T07:22:33Z

This PR (HEAD: feae769) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/527575.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-19T07:35:48Z

Message from Adam Cmiel:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-26T20:58:05Z

Message from Bryan Mills:

Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-26T20:58:05Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-26T20:47:41Z","revision":"f89578c43162e1ef553edb7104a5f8d2c36a5a67"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-26T21:14:37Z

Message from Bryan Mills:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-26T21:14:38Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-26T21:14:39Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527575.
After addressing review feedback, remember to publish your drafts!

In CL 197062, many errors related to go.sum were changed from base.Fatal to error returns. The malformed go.sum error was lost in the process. Currently, when go encounters a malformed go.sum file, go will read the well-formed part of the file and then silently ignore the rest. The motivation behind moving away from base.Fatal was to make the errors show up in -json output. Simply propagating the malformed go.sum error would not achieve this: - For an argument-less 'go mod download -json' with a go>=1.17 module, a malformed go.sum causes an error during LoadModGraph already, before go ever starts downloading modules and printing their JSON. - In other cases, a malformed go.sum would be reported as Error for one of the modules (presumably the one which gets downloaded first) but none of the others. - In either case, 'go mod download' manages to download enough data to succeed on a re-run, making the error look intermittent. Switch the error back to a Fatal one, but give 'go mod tidy' an exception to let it fix broken go.sum files. Fixes #62345 Change-Id: I066482b242165bcc6cbba0b2dab64901fad8619f GitHub-Last-Rev: feae769 GitHub-Pull-Request: #62588 Reviewed-on: https://go-review.googlesource.com/c/go/+/527575 Auto-Submit: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Than McIntosh <[email protected]>

gopherbot · 2023-09-27T14:26:56Z

This PR is being closed because golang.org/cl/527575 has been merged.

chmeliik force-pushed the malformed-gosum branch from 8608968 to b176d66 Compare September 14, 2023 16:38

chmeliik force-pushed the malformed-gosum branch from b176d66 to 40569c4 Compare September 14, 2023 16:57

chmeliik force-pushed the malformed-gosum branch from 40569c4 to b5d5478 Compare September 18, 2023 07:45

chmeliik force-pushed the malformed-gosum branch from b5d5478 to ae4603c Compare September 18, 2023 07:54

chmeliik force-pushed the malformed-gosum branch from ae4603c to 219ee55 Compare September 18, 2023 14:34

chmeliik force-pushed the malformed-gosum branch from 219ee55 to feae769 Compare September 19, 2023 07:18

gopherbot closed this Sep 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/go: make malformed go.sum a fatal error #62588

cmd/go: make malformed go.sum a fatal error #62588

chmeliik commented Sep 12, 2023 •

edited

Loading

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 19, 2023

gopherbot commented Sep 19, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 27, 2023

cmd/go: make malformed go.sum a fatal error #62588

cmd/go: make malformed go.sum a fatal error #62588

Conversation

chmeliik commented Sep 12, 2023 • edited Loading

gopherbot commented Sep 12, 2023

gopherbot commented Sep 12, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 15, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 18, 2023

gopherbot commented Sep 19, 2023

gopherbot commented Sep 19, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 26, 2023

gopherbot commented Sep 27, 2023

chmeliik commented Sep 12, 2023 •

edited

Loading