os: avoid TestFileChdir fail when GOROOT is a symbolic link #64001

qiulaidongfeng · 2023-11-08T11:43:52Z

If GOROOT is a symbolic link,
the paths obtained from the
first and second Getwd of TestFileChdir are different,
and this CL fixes the test failure in this situation.

Fixes #64281

gopherbot · 2023-11-08T11:49:18Z

This PR (HEAD: d849518) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/540521.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-08T11:56:15Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:10:06Z

Message from qiulaidongfeng:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:10:07Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:10:08Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:17:11Z

This PR (HEAD: 31cb871) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/540521.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-08T12:24:03Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:30:48Z

Message from qiulaidongfeng:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:37:30Z

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:37:31Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T12:44:14Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T13:31:01Z

This PR (HEAD: bd8c67f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/540521.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-08T13:44:41Z

Message from qiulaidongfeng:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T13:44:42Z

Message from Gopher Robot:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T13:51:56Z

This PR (HEAD: eba125a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/540521.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-08T14:06:03Z

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T14:06:04Z

Message from qiulaidongfeng:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T14:06:05Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-08T14:13:03Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-15T03:53:17Z

Message from qiulaidongfeng:

Patch Set 5: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-15T11:48:12Z

This PR (HEAD: 399c312) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/540521.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-15T22:49:16Z

Message from qiulaidongfeng:

Patch Set 6: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-15T22:56:39Z

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-15T23:03:54Z

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-17T14:14:48Z

Message from qiulaidongfeng:

Patch Set 6: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-18T10:43:29Z

Message from qiulaidongfeng:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T20:03:56Z

Message from Bryan Mills:

Patch Set 7: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T23:02:02Z

This PR (HEAD: 9e241a6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/540521.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

If GOROOT is a symbolic link, the paths obtained from the first and second Getwd of TestFileChdir are different, and this CL fixes the test failure in this situation.

gopherbot · 2023-11-20T23:08:57Z

This PR (HEAD: 5cc418e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/540521.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-20T23:15:36Z

Message from qiulaidongfeng:

Patch Set 9: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T23:22:11Z

Message from Gopher Robot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T23:28:43Z

Message from Bryan Mills:

Patch Set 9: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T23:35:13Z

Message from Gopher Robot:

Patch Set 9: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T00:07:44Z

Message from qiulaidongfeng:

Patch Set 9: -Run-TryBot

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T13:41:19Z

Message from qiulaidongfeng:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T15:41:32Z

Message from Bryan Mills:

Patch Set 9: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T15:49:24Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-21T15:34:51Z","revision":"0c5c2a9e12b108e5ddb722da0215cce4596cd1ed"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T16:05:24Z

Message from Bryan Mills:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T16:05:26Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T16:05:27Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/540521.
After addressing review feedback, remember to publish your drafts!

If GOROOT is a symbolic link, the paths obtained from the first and second Getwd of TestFileChdir are different, and this CL fixes the test failure in this situation. Fixes #64281 Change-Id: I53026b6c54a54be08833396e2c7081ca3ab8c282 GitHub-Last-Rev: 5cc418e GitHub-Pull-Request: #64001 Reviewed-on: https://go-review.googlesource.com/c/go/+/540521 Reviewed-by: Michael Knyszek <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2023-11-21T16:37:01Z

This PR is being closed because golang.org/cl/540521 has been merged.

qiulaidongfeng force-pushed the os-test branch from d849518 to 31cb871 Compare November 8, 2023 12:15

qiulaidongfeng force-pushed the os-test branch from 31cb871 to bd8c67f Compare November 8, 2023 13:23

qiulaidongfeng force-pushed the os-test branch from bd8c67f to eba125a Compare November 8, 2023 13:50

qiulaidongfeng force-pushed the os-test branch from eba125a to 399c312 Compare November 15, 2023 11:44

qiulaidongfeng force-pushed the os-test branch from 399c312 to 9e241a6 Compare November 20, 2023 23:01

os: avoid TestFileChdir fail when GOROOT is a symbolic link

5cc418e

If GOROOT is a symbolic link, the paths obtained from the first and second Getwd of TestFileChdir are different, and this CL fixes the test failure in this situation.

qiulaidongfeng force-pushed the os-test branch from 9e241a6 to 5cc418e Compare November 20, 2023 23:07

gopherbot closed this Nov 21, 2023

os: avoid TestFileChdir fail when GOROOT is a symbolic link #64001

os: avoid TestFileChdir fail when GOROOT is a symbolic link #64001

Conversation

qiulaidongfeng commented Nov 8, 2023 • edited Loading

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 15, 2023

gopherbot commented Nov 15, 2023

gopherbot commented Nov 15, 2023

gopherbot commented Nov 15, 2023

gopherbot commented Nov 15, 2023

gopherbot commented Nov 17, 2023

gopherbot commented Nov 18, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

qiulaidongfeng commented Nov 8, 2023 •

edited

Loading