-
Notifications
You must be signed in to change notification settings - Fork 18k
math/rand/v2: add Read method to ChaCha8 source #67498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I626b4cdcee75d56ef3d49c2abac765cde0b93999
This PR (HEAD: 5a4b225) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586615. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-18T08:11:30Z","revision":"acb8b0c3cc1e86295299655a8ecdefbf0a72469c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Change-Id: I017c46eb13e5838c74b4faa51c143f7d43f12584
This PR (HEAD: 9cea191) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586615. Important tips:
|
Change-Id: I2d7f4a902877c209b6aa793f108856b750f25d8b
This PR (HEAD: 18c2a41) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586615. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-18T15:12:04Z","revision":"9ae96e3c6033cb068ce0f9edb4ef4168656fc570"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 3: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Change-Id: I2d4f667000c78998ed783da0786c93049b7dcc2f
Change-Id: Iaedf3c4dc5220679ed40cfcf3ce9d30461e828e0
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
This PR (HEAD: 9cd019b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586615. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 4: Commit-Queue+1 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-18T15:30:21Z","revision":"4145a0ed7d1c566a165e561aa5f7b259ed2b9053"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Gopher Robot: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Gopher Robot: Patch Set 4: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 4: -Run-TryBot Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Change-Id: I330a6cfb8d90c00ad86f457ea6b54c6197dffd15
This PR (HEAD: e3db1b8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586615. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-19T09:54:15Z","revision":"58d1d5629ced0c3430252821f7cc77486bcee796"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Mateusz Poliwczak: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Message from Filippo Valsorda: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586615. |
Performance on amd64:
Read/1-12 118.7Mi ± 1%
Read/2-12 239.6Mi ± 0%
Read/3-12 353.1Mi ± 1%
Read/4-12 482.8Mi ± 1%
Read/8-12 949.9Mi ± 1%
Read/16-12 1.313Gi ± 1%
Read/32-12 1.795Gi ± 0%
Read/64-12 2.083Gi ± 1%
Read/128-12 2.249Gi ± 2%
Read/256-12 2.314Gi ± 1%
Read/512-12 2.355Gi ± 1%
Read/1024-12 2.384Gi ± 0%
Read/2048-12 2.373Gi ± 3%
Read/16384-12 2.415Gi ± 0%
geomean 1.090Gi
Fixes #67059