-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: avoid when go.env contain GOTOOLCHAIN=local test fail #67807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes golang#67793 Change-Id: Idb079c18c9f4565d95fbf979c73e578872d3732f
This PR (HEAD: 12b6246) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/590196. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from qiu laidongfeng2: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-04T13:03:29Z","revision":"30014baa14b82049c12e09a6df638c94bfdcfcc2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from qiu laidongfeng2: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from Michael Matloob: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from qiu laidongfeng2: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
Message from Sam Thanawalla: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590196. |
The test fail when $GOROOT/go.env contain GOTOOLCHAIN=local because GOTOOLCHAIN=local is assumed to be a non-default value. This CL fixed the test failure by using go.env from the test as $GOROOT/go.env throughout the test. Test have also been added to ensure that when $GOROOT/go.env contain GOTOOLCHAIN=local, GOTOOLCHAIN=local is not taken as a non-default value. Fixes #67793 Change-Id: Ibc5057d38d36c6c55726a039de1e7c37d6935b52 GitHub-Last-Rev: 12b6246 GitHub-Pull-Request: #67807 Reviewed-on: https://go-review.googlesource.com/c/go/+/590196 Reviewed-by: Sam Thanawalla <[email protected]> Reviewed-by: Michael Matloob <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/590196 has been merged. |
The test fail when $GOROOT/go.env contain GOTOOLCHAIN=local
because GOTOOLCHAIN=local is assumed to be a non-default value.
This CL fixed the test failure
by using go.env from the test as $GOROOT/go.env throughout the test.
Test have also been added to ensure that
when $GOROOT/go.env contain GOTOOLCHAIN=local,
GOTOOLCHAIN=local is not taken as a non-default value.
Fixes #67793