This repository was archived by the owner on May 9, 2021. It is now read-only.
Suggest io.SeekXXX instead of os.SEEK_XXX #302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a new lint function to suggest new constant replacing a depreciated constant. os.SEEK_SET => io.SeekStart os.SEEK_CUR => io.SeekCurrent os.SEEK_END => io.SeekEnd Fixes golang#294
|
Also, it's missing the error reporting convention with line number, I'm working on it. |
dsnet
reviewed
Jun 15, 2017
lint.go
Outdated
| @@ -210,6 +210,7 @@ func (f *file) lint() { | |||
| f.lintTimeNames() | |||
| f.lintContextKeyTypes() | |||
| f.lintContextArgs() | |||
| f.lintDepreciatedConstants() | |||
There was a problem hiding this comment.
Rename Depreciated as Deprecated.
Depreciate means to lower in value. Deprecated means to express disapproval of.
|
Friendly ping @dsnet, the small change you requested has been done, what's next? |
andybons
suggested changes
Feb 21, 2018
| } | ||
|
|
||
| // lintDeprecatedConstants checks for the use of a deprecated constant | ||
| // and suggest a different constant in replacement |
There was a problem hiding this comment.
s/suggest/suggests
Also comments should have a period at the end (was lint run on the code? ;)
There was a problem hiding this comment.
Also merge conflicts need to be resolved.
|
@dsnet fair. Since both fall outside the scope of the tool, closing this one as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new lint function to suggest new constant replacing a depreciated constant.
os.SEEK_SET => io.SeekStart
os.SEEK_CUR => io.SeekCurrent
os.SEEK_END => io.SeekEnd
Fixes #294
Hi! @shurcooL @dsnet
Can you please review it?