-
Notifications
You must be signed in to change notification settings - Fork 788
cmd/gomobile: specify clang++ compiler for C++ compilation, setup CGO_CXXFLAGS #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 7c3232d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/134975 to see it. Tip: You can toggle comments from me using the |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Fixes golang/go#17343 and golang/go#27508 |
Message from Gerrit User 7435: Patch Set 1: (2 comments) Thank you. A few tweaks to the commit message and this can go in. Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Message from Gerrit User 12446: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Message from Gerrit User 29177: Patch Set 3: (2 comments) Thanks for the tips. Updated Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Message from Gerrit User 7435: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Message from Gerrit User 7435: Patch Set 3:
"Nit", not "not". Phone corrected me. Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Message from Gerrit User 12446: Uploaded patch set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
Message from Gerrit User 29177: Patch Set 4: (1 comment) Fixed that too :) Please don’t reply on this GitHub thread. Visit golang.org/cl/134975. |
…_CXXFLAGS Fixes #27508, #17343 Change-Id: I3e50ae781012a093254f7f8d6d719d89426f04a9 GitHub-Last-Rev: 7c3232d GitHub-Pull-Request: #20 Reviewed-on: https://go-review.googlesource.com/134975 Reviewed-by: Elias Naur <[email protected]>
This PR is being closed because golang.org/cl/134975 has been merged. |
…_CXXFLAGS Fixes #27508, #17343 Change-Id: I3e50ae781012a093254f7f8d6d719d89426f04a9 GitHub-Last-Rev: 7c3232d GitHub-Pull-Request: golang#20 Reviewed-on: https://go-review.googlesource.com/134975 Reviewed-by: Elias Naur <[email protected]>
…_CXXFLAGS Fixes #27508, #17343 Change-Id: I3e50ae781012a093254f7f8d6d719d89426f04a9 GitHub-Last-Rev: 7c3232d GitHub-Pull-Request: golang#20 Reviewed-on: https://go-review.googlesource.com/134975 Reviewed-by: Elias Naur <[email protected]>
Fixes #27508, #17343