Skip to content

cmd/gomobile: specify clang++ compiler for C++ compilation, setup CGO_CXXFLAGS #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tadovas
Copy link
Contributor

@tadovas tadovas commented Sep 12, 2018

Fixes #27508, #17343

@gopherbot
Copy link
Contributor

This PR (HEAD: 7c3232d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/134975 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@tadovas
Copy link
Contributor Author

tadovas commented Sep 12, 2018

Fixes golang/go#17343 and golang/go#27508

@gopherbot
Copy link
Contributor

Message from Gerrit User 7435:

Patch Set 1:

(2 comments)

Thank you. A few tweaks to the commit message and this can go in.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@tadovas tadovas changed the title Specify clang++ compiler for C++ compilation, setup CGO_CXXFLAGS cmd/gomobile: Specify clang++ compiler for C++ compilation, setup CGO_CXXFLAGS Sep 12, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 29177:

Patch Set 3:

(2 comments)

Thanks for the tips. Updated


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 7435:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 7435:

Patch Set 3:

Patch Set 3:

(1 comment)

"Nit", not "not". Phone corrected me.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@tadovas tadovas changed the title cmd/gomobile: Specify clang++ compiler for C++ compilation, setup CGO_CXXFLAGS cmd/gomobile: specify clang++ compiler for C++ compilation, setup CGO_CXXFLAGS Sep 13, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 29177:

Patch Set 4:

(1 comment)

Fixed that too :)


Please don’t reply on this GitHub thread. Visit golang.org/cl/134975.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 13, 2018
…_CXXFLAGS

Fixes #27508, #17343

Change-Id: I3e50ae781012a093254f7f8d6d719d89426f04a9
GitHub-Last-Rev: 7c3232d
GitHub-Pull-Request: #20
Reviewed-on: https://go-review.googlesource.com/134975
Reviewed-by: Elias Naur <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/134975 has been merged.

@gopherbot gopherbot closed this Sep 13, 2018
@tadovas tadovas deleted the improvement/fix-CXX-env branch September 13, 2018 08:28
imWildCat pushed a commit to imWildCat/go-mobile that referenced this pull request Apr 10, 2021
…_CXXFLAGS

Fixes #27508, #17343

Change-Id: I3e50ae781012a093254f7f8d6d719d89426f04a9
GitHub-Last-Rev: 7c3232d
GitHub-Pull-Request: golang#20
Reviewed-on: https://go-review.googlesource.com/134975
Reviewed-by: Elias Naur <[email protected]>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this pull request Apr 11, 2021
…_CXXFLAGS

Fixes #27508, #17343

Change-Id: I3e50ae781012a093254f7f8d6d719d89426f04a9
GitHub-Last-Rev: 7c3232d
GitHub-Pull-Request: golang#20
Reviewed-on: https://go-review.googlesource.com/134975
Reviewed-by: Elias Naur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants