Skip to content

bind: ignore type aliases to basic types #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

federicobond
Copy link
Contributor

@federicobond federicobond commented Jan 24, 2019

@gopherbot
Copy link
Contributor

This PR (HEAD: f2a35ab) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/159417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Elias Naur:

Patch Set 1:

(1 comment)

Thank you for the fix. Please fix the commit message and add tests to bind/testdata/. You can run the tests with go test ./bind and update the golden files with go test ./bind -update.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 814989c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/159417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: c5d4a48) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/159417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Federico Bond:

Patch Set 4: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Federico Bond:

Patch Set 5:

Patch Set 1:

(1 comment)

Thank you for the fix. Please fix the commit message and add tests to bind/testdata/. You can run the tests with go test ./bind and update the golden files with go test ./bind -update.

Done.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Federico Bond:

Patch Set 6: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Federico Bond:

Patch Set 7: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Elias Naur:

Patch Set 8:

I believe you need to update the original pull request message at

#25

to ensure Gobot won't overwrite your message.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

@federicobond federicobond changed the title Fix type aliases to basic types bind: ignore type aliases to basic types Jan 25, 2019
@gopherbot
Copy link
Contributor

Message from Federico Bond:

Patch Set 8:

Patch Set 8:

I believe you need to update the original pull request message at

#25

to ensure Gobot won't overwrite your message.

Thanks, I hadn't noticed that.


Please don’t reply on this GitHub thread. Visit golang.org/cl/159417.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 25, 2019
Fixes golang/go#29559

Change-Id: Iffaac239e5c9a9e53f4e292b4d9bf669d5084e1f
GitHub-Last-Rev: c5d4a48
GitHub-Pull-Request: #25
Reviewed-on: https://go-review.googlesource.com/c/159417
Reviewed-by: Elias Naur <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/159417 has been merged.

@gopherbot gopherbot closed this Jan 25, 2019
@federicobond federicobond deleted the fix-type-aliases branch January 27, 2019 15:33
imWildCat pushed a commit to imWildCat/go-mobile that referenced this pull request Apr 10, 2021
Fixes golang/go#29559

Change-Id: Iffaac239e5c9a9e53f4e292b4d9bf669d5084e1f
GitHub-Last-Rev: c5d4a48
GitHub-Pull-Request: golang#25
Reviewed-on: https://go-review.googlesource.com/c/159417
Reviewed-by: Elias Naur <[email protected]>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this pull request Apr 11, 2021
Fixes golang/go#29559

Change-Id: Iffaac239e5c9a9e53f4e292b4d9bf669d5084e1f
GitHub-Last-Rev: c5d4a48
GitHub-Pull-Request: golang#25
Reviewed-on: https://go-review.googlesource.com/c/159417
Reviewed-by: Elias Naur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants