-
Notifications
You must be signed in to change notification settings - Fork 787
bind: ignore type aliases to basic types #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: f2a35ab) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/159417 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
Message from Elias Naur: Patch Set 1: (1 comment) Thank you for the fix. Please fix the commit message and add tests to bind/testdata/. You can run the tests with go test ./bind and update the golden files with go test ./bind -update. Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
f2a35ab
to
814989c
Compare
This PR (HEAD: 814989c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/159417 to see it. Tip: You can toggle comments from me using the |
814989c
to
c5d4a48
Compare
This PR (HEAD: c5d4a48) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/159417 to see it. Tip: You can toggle comments from me using the |
Message from Federico Bond: Patch Set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
Message from Federico Bond: Patch Set 5:
Done. Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
Message from Federico Bond: Patch Set 6: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
Message from Federico Bond: Patch Set 7: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
Message from Elias Naur: Patch Set 8: I believe you need to update the original pull request message at to ensure Gobot won't overwrite your message. Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
Message from Federico Bond: Patch Set 8:
Thanks, I hadn't noticed that. Please don’t reply on this GitHub thread. Visit golang.org/cl/159417. |
Fixes golang/go#29559 Change-Id: Iffaac239e5c9a9e53f4e292b4d9bf669d5084e1f GitHub-Last-Rev: c5d4a48 GitHub-Pull-Request: #25 Reviewed-on: https://go-review.googlesource.com/c/159417 Reviewed-by: Elias Naur <[email protected]>
This PR is being closed because golang.org/cl/159417 has been merged. |
Fixes golang/go#29559 Change-Id: Iffaac239e5c9a9e53f4e292b4d9bf669d5084e1f GitHub-Last-Rev: c5d4a48 GitHub-Pull-Request: golang#25 Reviewed-on: https://go-review.googlesource.com/c/159417 Reviewed-by: Elias Naur <[email protected]>
Fixes golang/go#29559 Change-Id: Iffaac239e5c9a9e53f4e292b4d9bf669d5084e1f GitHub-Last-Rev: c5d4a48 GitHub-Pull-Request: golang#25 Reviewed-on: https://go-review.googlesource.com/c/159417 Reviewed-by: Elias Naur <[email protected]>
Fixes golang/go#29559